-
Notifications
You must be signed in to change notification settings - Fork 13.4k
[WIP] Use weak aliases for the allocator shim #142366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
r? @SparrowLii rustbot has assigned @SparrowLii. Use |
Some changes occurred in compiler/rustc_codegen_ssa Some changes occurred in coverage instrumentation. cc @Zalathar |
@bors2 try jobs=x86_64-msvc-1,x86_64-msvc-2 |
[WIP] Use weak aliases for the allocator shim try-job: x86_64-msvc-1 try-job: x86_64-msvc-2
This comment has been minimized.
This comment has been minimized.
@bors2 try cancel forgot to fix warnings.... @bors2 try jobs=x86_64-msvc-1,x86_64-msvc-2 |
Try build cancelled. Cancelled workflows: |
[WIP] Use weak aliases for the allocator shim try-job: x86_64-msvc-1 try-job: x86_64-msvc-2
This comment has been minimized.
This comment has been minimized.
💔 Test failed
|
@bors2 try jobs=x86_64-msvc-1,x86_64-msvc-2 |
[WIP] Use weak aliases for the allocator shim try-job: x86_64-msvc-1 try-job: x86_64-msvc-2
This comment has been minimized.
This comment has been minimized.
💔 Test failed
|
Some changes occurred in compiler/rustc_codegen_gcc |
@bors2 try jobs=x86_64-msvc-1,x86_64-msvc-2 |
[WIP] Use weak aliases for the allocator shim try-job: x86_64-msvc-1 try-job: x86_64-msvc-2
This comment has been minimized.
This comment has been minimized.
💔 Test failed
|
All test failures seem to involve LTO. I suspect that the |
And the weak symbol problem was caused by /export not being in an object file?
@bors2 try jobs=x86_64-msvc-1,x86_64-msvc-2 |
[WIP] Use weak aliases for the allocator shim try-job: x86_64-msvc-1 try-job: x86_64-msvc-2
The job Click to see the possible cause of the failure (guessed by this bot)
|
💔 Test failed
|
So close...
The exit code is STATUS_DLL_NOT_FOUND, no idea why stripping breaks things. |
No description provided.