Clarify the meaning of AttributeOrder::KeepFirst and AttributeOrder::KeepLast
#143603
+15
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-attributes
|
Some changes occurred in compiler/rustc_attr_parsing |
Periodic1911
force-pushed
the
clarify_keepfistlast
branch
from
1b804a5 to
6254afa
Compare
JonathanBrouwer
approved these changes
Jul 7, 2025
compiler-errors
changed the title
AttributeOrder::KeepFirst and `AttributeOrde…AttributeOrder::KeepFirst and AttributeOrder::KeepLast
|
r? compiler-errors @bors r+ rollup |
bors
added
S-waiting-on-bors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify the meaning of
KeepLastandKeepFirstfor #131229 (comment)Just a minor clarification, but me and @JonathanBrouwer have confused these two a few times so I think it's warranted.
r? @oli-obk
cc @JonathanBrouwer