Skip to content

Stabilize const_float_round_methods #143604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Stabilize const_float_round_methods #143604

wants to merge 2 commits into from
+32 −38

Conversation

nxsaken
Copy link
Contributor

@nxsaken nxsaken commented Jul 7, 2025 •
edited
Loading

Closes #141555, waiting for FCP.

@rustbot
Copy link
Collaborator

rustbot commented Jul 7, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 7, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@nxsaken nxsaken force-pushed the const_float_round_methods branch from 2fc9d9b to 5df1124 Compare July 7, 2025 19:39
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@nxsaken nxsaken marked this pull request as draft July 7, 2025 19:56
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 7, 2025
@nxsaken nxsaken force-pushed the const_float_round_methods branch from 5df1124 to c7002be Compare July 7, 2025 20:24
@nxsaken nxsaken marked this pull request as ready for review July 7, 2025 21:04
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 7, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jul 7, 2025

Some changes occurred to the intrinsics. Make sure the CTFE / Miri interpreter
gets adapted for the changes, if necessary.

cc @rust-lang/miri, @RalfJung, @oli-obk, @lcnr

nxsaken
nxsaken commented Jul 7, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RalfJung RalfJung RalfJung left review comments

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tracking Issue for #![feature(const_float_round_methods)]
5 participants
@nxsaken @rustbot @rust-log-analyzer @RalfJung @Mark-Simulacrum