Skip to content

addcarryx: use pointers of the right type #1589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Jun 21, 2024

I don't know why these functions use u8 in their signature, but surely they must actually be writing a u32/u64?

I also synced the doc comments between addcarry and addcarryx.

@rustbot
Copy link
Collaborator

rustbot commented Jun 21, 2024

r? @Amanieu

rustbot has assigned @Amanieu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@Amanieu
Copy link
Member

Amanieu commented Jun 21, 2024

Presumably this was relevant when LLVM used typed pointers, but this isn't the case now that it has switched to opaque pointers.

@Amanieu Amanieu enabled auto-merge (rebase) June 21, 2024 09:54
@Amanieu Amanieu merged commit dfb414e into rust-lang:master Jun 21, 2024
29 checks passed
@RalfJung RalfJung deleted the addcarryx branch June 21, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants