Skip to content

build(deps): bump the rust-vmm group across 2 directories with 4 updates #849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 7, 2025

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 7, 2025

Bumps the rust-vmm group with 3 updates in the / directory: vhost-user-backend, virtio-queue and virtio-vsock.
Bumps the rust-vmm group with 2 updates in the /staging directory: vhost-user-backend and virtio-queue.

Updates vhost-user-backend from 0.19.0 to 0.20.0

Release notes

Sourced from vhost-user-backend's releases.

vhost-user-backend v0.20.0

Changed

  • [306] Updated virtio-queue to v0.16.0 and virtio-bindings to v0.2.6
Commits
  • eae4f73 vhost-user-backend: Prepare for new release v0.20.0
  • 3db761b build: Update virtio-queue and virtio-bindings
  • 82e09ed vhost: Fix broken link in vhost/README.md
  • f9b25c2 vhost: Fix building docs
  • 03ba6ea vhost: correct 'trucate' to 'truncate'
  • 9a744c2 vhost: Fix clippy warning from nightly compiler
  • See full diff in compare view

Updates virtio-bindings from 0.2.5 to 0.2.6

Release notes

Sourced from virtio-bindings's releases.

virtio-bindings-v0.2.6

Changed

  • Bindings are now once again distributed with the crate, rather than generated at build time.
  • Regenerate bindings with Linux 6.15.
  • Remove unused feature flags and build dependencies.
Commits
  • d3795a5 Bump virtio-queue-ser to v0.13.0
  • 84b01b8 virtio-vsock: prepare v0.10.0 release
  • 0d03d7d virtio-queue-ser: Prepare for v0.13.0 release
  • c87932c virtio-queue: Prepare v0.16.0 release
  • 5183b9b virtio-bindings: Prepare v0.2.6 release
  • 3236c5b virtio-bindings: Remove unused feature flags
  • 0bb9d37 virtio-bindings: Remove bindgen from build deps
  • 6b4bf61 virtio-bindings: regenerate with Linux 6.15
  • 1b5087f virtio-bindings: check in generated bindings again
  • 9e86fac virtio-queue: Fix warning from nightly compiler
  • Additional commits viewable in compare view

Updates virtio-queue from 0.15.0 to 0.16.0

Commits
  • d3795a5 Bump virtio-queue-ser to v0.13.0
  • 84b01b8 virtio-vsock: prepare v0.10.0 release
  • 0d03d7d virtio-queue-ser: Prepare for v0.13.0 release
  • c87932c virtio-queue: Prepare v0.16.0 release
  • 5183b9b virtio-bindings: Prepare v0.2.6 release
  • 3236c5b virtio-bindings: Remove unused feature flags
  • 0bb9d37 virtio-bindings: Remove bindgen from build deps
  • 6b4bf61 virtio-bindings: regenerate with Linux 6.15
  • 1b5087f virtio-bindings: check in generated bindings again
  • 9e86fac virtio-queue: Fix warning from nightly compiler
  • Additional commits viewable in compare view

Updates virtio-vsock from 0.9.0 to 0.10.0

Commits
  • d3795a5 Bump virtio-queue-ser to v0.13.0
  • 84b01b8 virtio-vsock: prepare v0.10.0 release
  • 0d03d7d virtio-queue-ser: Prepare for v0.13.0 release
  • c87932c virtio-queue: Prepare v0.16.0 release
  • 5183b9b virtio-bindings: Prepare v0.2.6 release
  • 3236c5b virtio-bindings: Remove unused feature flags
  • 0bb9d37 virtio-bindings: Remove bindgen from build deps
  • 6b4bf61 virtio-bindings: regenerate with Linux 6.15
  • 1b5087f virtio-bindings: check in generated bindings again
  • 9e86fac virtio-queue: Fix warning from nightly compiler
  • See full diff in compare view

Updates vhost-user-backend from 0.19.0 to 0.20.0

Release notes

Sourced from vhost-user-backend's releases.

vhost-user-backend v0.20.0

Changed

  • [306] Updated virtio-queue to v0.16.0 and virtio-bindings to v0.2.6
Commits
  • eae4f73 vhost-user-backend: Prepare for new release v0.20.0
  • 3db761b build: Update virtio-queue and virtio-bindings
  • 82e09ed vhost: Fix broken link in vhost/README.md
  • f9b25c2 vhost: Fix building docs
  • 03ba6ea vhost: correct 'trucate' to 'truncate'
  • 9a744c2 vhost: Fix clippy warning from nightly compiler
  • See full diff in compare view

Updates virtio-bindings from 0.2.5 to 0.2.6

Release notes

Sourced from virtio-bindings's releases.

virtio-bindings-v0.2.6

Changed

  • Bindings are now once again distributed with the crate, rather than generated at build time.
  • Regenerate bindings with Linux 6.15.
  • Remove unused feature flags and build dependencies.
Commits
  • d3795a5 Bump virtio-queue-ser to v0.13.0
  • 84b01b8 virtio-vsock: prepare v0.10.0 release
  • 0d03d7d virtio-queue-ser: Prepare for v0.13.0 release
  • c87932c virtio-queue: Prepare v0.16.0 release
  • 5183b9b virtio-bindings: Prepare v0.2.6 release
  • 3236c5b virtio-bindings: Remove unused feature flags
  • 0bb9d37 virtio-bindings: Remove bindgen from build deps
  • 6b4bf61 virtio-bindings: regenerate with Linux 6.15
  • 1b5087f virtio-bindings: check in generated bindings again
  • 9e86fac virtio-queue: Fix warning from nightly compiler
  • Additional commits viewable in compare view

Updates virtio-queue from 0.15.0 to 0.16.0

Commits
  • d3795a5 Bump virtio-queue-ser to v0.13.0
  • 84b01b8 virtio-vsock: prepare v0.10.0 release
  • 0d03d7d virtio-queue-ser: Prepare for v0.13.0 release
  • c87932c virtio-queue: Prepare v0.16.0 release
  • 5183b9b virtio-bindings: Prepare v0.2.6 release
  • 3236c5b virtio-bindings: Remove unused feature flags
  • 0bb9d37 virtio-bindings: Remove bindgen from build deps
  • 6b4bf61 virtio-bindings: regenerate with Linux 6.15
  • 1b5087f virtio-bindings: check in generated bindings again
  • 9e86fac virtio-queue: Fix warning from nightly compiler
  • Additional commits viewable in compare view

Updates vhost-user-backend from 0.19.0 to 0.20.0

Release notes

Sourced from vhost-user-backend's releases.

vhost-user-backend v0.20.0

Changed

  • [306] Updated virtio-queue to v0.16.0 and virtio-bindings to v0.2.6
Commits
  • eae4f73 vhost-user-backend: Prepare for new release v0.20.0
  • 3db761b build: Update virtio-queue and virtio-bindings
  • 82e09ed vhost: Fix broken link in vhost/README.md
  • f9b25c2 vhost: Fix building docs
  • 03ba6ea vhost: correct 'trucate' to 'truncate'
  • 9a744c2 vhost: Fix clippy warning from nightly compiler
  • See full diff in compare view

Updates virtio-bindings from 0.2.5 to 0.2.6

Release notes

Sourced from virtio-bindings's releases.

virtio-bindings-v0.2.6

Changed

  • Bindings are now once again distributed with the crate, rather than generated at build time.
  • Regenerate bindings with Linux 6.15.
  • Remove unused feature flags and build dependencies.
Commits
  • d3795a5 Bump virtio-queue-ser to v0.13.0
  • 84b01b8 virtio-vsock: prepare v0.10.0 release
  • 0d03d7d virtio-queue-ser: Prepare for v0.13.0 release
  • c87932c virtio-queue: Prepare v0.16.0 release
  • 5183b9b virtio-bindings: Prepare v0.2.6 release
  • 3236c5b virtio-bindings: Remove unused feature flags
  • 0bb9d37 virtio-bindings: Remove bindgen from build deps
  • 6b4bf61 virtio-bindings: regenerate with Linux 6.15
  • 1b5087f virtio-bindings: check in generated bindings again
  • 9e86fac virtio-queue: Fix warning from nightly compiler
  • Additional commits viewable in compare view

Updates virtio-queue from 0.15.0 to 0.16.0

Commits
  • d3795a5 Bump virtio-queue-ser to v0.13.0
  • 84b01b8 virtio-vsock: prepare v0.10.0 release
  • 0d03d7d virtio-queue-ser: Prepare for v0.13.0 release
  • c87932c virtio-queue: Prepare v0.16.0 release
  • 5183b9b virtio-bindings: Prepare v0.2.6 release
  • 3236c5b virtio-bindings: Remove unused feature flags
  • 0bb9d37 virtio-bindings: Remove bindgen from build deps
  • 6b4bf61 virtio-bindings: regenerate with Linux 6.15
  • 1b5087f virtio-bindings: check in generated bindings again
  • 9e86fac virtio-queue: Fix warning from nightly compiler
  • Additional commits viewable in compare view

Updates vhost-user-backend from 0.19.0 to 0.20.0

Release notes

Sourced from vhost-user-backend's releases.

vhost-user-backend v0.20.0

Changed

  • [306] Updated virtio-queue to v0.16.0 and virtio-bindings to v0.2.6
Commits
  • eae4f73 vhost-user-backend: Prepare for new release v0.20.0
  • 3db761b build: Update virtio-queue and virtio-bindings
  • 82e09ed vhost: Fix broken link in vhost/README.md
  • f9b25c2 vhost: Fix building docs
  • 03ba6ea vhost: correct 'trucate' to 'truncate'
  • 9a744c2 vhost: Fix clippy warning from nightly compiler
  • See full diff in compare view

Updates virtio-bindings from 0.2.5 to 0.2.6

Release notes

Sourced from virtio-bindings's releases.

virtio-bindings-v0.2.6

Changed

  • Bindings are now once again distributed with the crate, rather than generated at build time.
  • Regenerate bindings with Linux 6.15.
  • Remove unused feature flags and build dependencies.
Commits
  • d3795a5 Bump virtio-queue-ser to v0.13.0
  • 84b01b8 virtio-vsock: prepare v0.10.0 release
  • 0d03d7d virtio-queue-ser: Prepare for v0.13.0 release
  • c87932c virtio-queue: Prepare v0.16.0 release
  • 5183b9b virtio-bindings: Prepare v0.2.6 release
  • 3236c5b virtio-bindings: Remove unused feature flags
  • 0bb9d37 virtio-bindings: Remove bindgen from build deps
  • 6b4bf61 virtio-bindings: regenerate with Linux 6.15
  • 1b5087f virtio-bindings: check in generated bindings again
  • 9e86fac virtio-queue: Fix warning from nightly compiler
  • Additional commits viewable in compare view

Updates virtio-queue from 0.15.0 to 0.16.0

Commits
  • d3795a5 Bump virtio-queue-ser to v0.13.0
  • 84b01b8 virtio-vsock: prepare v0.10.0 release
  • 0d03d7d virtio-queue-ser: Prepare for v0.13.0 release
  • c87932c virtio-queue: Prepare v0.16.0 release
  • 5183b9b virtio-bindings: Prepare v0.2.6 release
  • 3236c5b virtio-bindings: Remove unused feature flags
  • 0bb9d37 virtio-bindings: Remove bindgen from build deps
  • 6b4bf61 virtio-bindings: regenerate with Linux 6.15
  • 1b5087f virtio-bindings: check in generated bindings again
  • 9e86fac virtio-queue: Fix warning from nightly compiler
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

Bumps the rust-vmm group with 3 updates in the / directory: [vhost-user-backend](https://github.com/rust-vmm/vhost), [virtio-queue](https://github.com/rust-vmm/vm-virtio) and [virtio-vsock](https://github.com/rust-vmm/vm-virtio).
Bumps the rust-vmm group with 2 updates in the /staging directory: [vhost-user-backend](https://github.com/rust-vmm/vhost) and [virtio-queue](https://github.com/rust-vmm/vm-virtio).


Updates `vhost-user-backend` from 0.19.0 to 0.20.0
- [Release notes](https://github.com/rust-vmm/vhost/releases)
- [Commits](rust-vmm/vhost@vhost-user-backend-v0.19.0...vhost-user-backend-v0.20.0)

Updates `virtio-bindings` from 0.2.5 to 0.2.6
- [Release notes](https://github.com/rust-vmm/vm-virtio/releases)
- [Commits](rust-vmm/vm-virtio@virtio-bindings-v0.2.5...virtio-bindings-v0.2.6)

Updates `virtio-queue` from 0.15.0 to 0.16.0
- [Release notes](https://github.com/rust-vmm/vm-virtio/releases)
- [Commits](rust-vmm/vm-virtio@virtio-queue-v0.15.0...virtio-queue-v0.16.0)

Updates `virtio-vsock` from 0.9.0 to 0.10.0
- [Release notes](https://github.com/rust-vmm/vm-virtio/releases)
- [Commits](rust-vmm/vm-virtio@virtio-vsock-v0.9.0...virtio-vsock-v0.10.0)

Updates `vhost-user-backend` from 0.19.0 to 0.20.0
- [Release notes](https://github.com/rust-vmm/vhost/releases)
- [Commits](rust-vmm/vhost@vhost-user-backend-v0.19.0...vhost-user-backend-v0.20.0)

Updates `virtio-bindings` from 0.2.5 to 0.2.6
- [Release notes](https://github.com/rust-vmm/vm-virtio/releases)
- [Commits](rust-vmm/vm-virtio@virtio-bindings-v0.2.5...virtio-bindings-v0.2.6)

Updates `virtio-queue` from 0.15.0 to 0.16.0
- [Release notes](https://github.com/rust-vmm/vm-virtio/releases)
- [Commits](rust-vmm/vm-virtio@virtio-queue-v0.15.0...virtio-queue-v0.16.0)

Updates `vhost-user-backend` from 0.19.0 to 0.20.0
- [Release notes](https://github.com/rust-vmm/vhost/releases)
- [Commits](rust-vmm/vhost@vhost-user-backend-v0.19.0...vhost-user-backend-v0.20.0)

Updates `virtio-bindings` from 0.2.5 to 0.2.6
- [Release notes](https://github.com/rust-vmm/vm-virtio/releases)
- [Commits](rust-vmm/vm-virtio@virtio-bindings-v0.2.5...virtio-bindings-v0.2.6)

Updates `virtio-queue` from 0.15.0 to 0.16.0
- [Release notes](https://github.com/rust-vmm/vm-virtio/releases)
- [Commits](rust-vmm/vm-virtio@virtio-queue-v0.15.0...virtio-queue-v0.16.0)

Updates `vhost-user-backend` from 0.19.0 to 0.20.0
- [Release notes](https://github.com/rust-vmm/vhost/releases)
- [Commits](rust-vmm/vhost@vhost-user-backend-v0.19.0...vhost-user-backend-v0.20.0)

Updates `virtio-bindings` from 0.2.5 to 0.2.6
- [Release notes](https://github.com/rust-vmm/vm-virtio/releases)
- [Commits](rust-vmm/vm-virtio@virtio-bindings-v0.2.5...virtio-bindings-v0.2.6)

Updates `virtio-queue` from 0.15.0 to 0.16.0
- [Release notes](https://github.com/rust-vmm/vm-virtio/releases)
- [Commits](rust-vmm/vm-virtio@virtio-queue-v0.15.0...virtio-queue-v0.16.0)

---
updated-dependencies:
- dependency-name: vhost-user-backend
  dependency-version: 0.20.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: rust-vmm
- dependency-name: virtio-bindings
  dependency-version: 0.2.6
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: rust-vmm
- dependency-name: virtio-queue
  dependency-version: 0.16.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: rust-vmm
- dependency-name: virtio-vsock
  dependency-version: 0.10.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: rust-vmm
- dependency-name: vhost-user-backend
  dependency-version: 0.20.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: rust-vmm
- dependency-name: virtio-bindings
  dependency-version: 0.2.6
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: rust-vmm
- dependency-name: virtio-queue
  dependency-version: 0.16.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: rust-vmm
- dependency-name: vhost-user-backend
  dependency-version: 0.20.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: rust-vmm
- dependency-name: virtio-bindings
  dependency-version: 0.2.6
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: rust-vmm
- dependency-name: virtio-queue
  dependency-version: 0.16.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: rust-vmm
- dependency-name: vhost-user-backend
  dependency-version: 0.20.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: rust-vmm
- dependency-name: virtio-bindings
  dependency-version: 0.2.6
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: rust-vmm
- dependency-name: virtio-queue
  dependency-version: 0.16.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: rust-vmm
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file rust Pull requests that update Rust code labels Jul 7, 2025
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jul 7, 2025
@dependabot dependabot bot added the rust Pull requests that update Rust code label Jul 7, 2025
@epilys epilys enabled auto-merge (rebase) July 7, 2025 06:39
@epilys epilys merged commit e1ef9d0 into main Jul 7, 2025
2 checks passed
@dependabot dependabot bot deleted the dependabot/cargo/rust-vmm-297929b070 branch July 7, 2025 07:40
@epilys
Copy link
Member

epilys commented Jul 8, 2025

This PR didn't trigger the CI at all. It appears to have broken compilation of vhost-device-scsi:

vhost-device-scsi % cargo test
   Compiling vhost-device-scsi v0.1.0
error[E0432]: unresolved import `virtio_queue::mock`
   --> vhost-device-scsi/src/vhu_scsi.rs:339:9
    |
339 |         mock::MockSplitQueue,
    |         ^^^^ could not find `mock` in `virtio_queue`
    |
note: found an item that was configured out
   --> .cargo/registry/src/index.crates.io-1949cf8c6b5b557f/virtio-queue-0.16.0/src/lib.rs:34:9
    |
34  | pub mod mock;
    |         ^^^^
note: the item is gated here
   --> .cargo/registry/src/index.crates.io-1949cf8c6b5b557f/virtio-queue-0.16.0/src/lib.rs:33:1
    |
33  | #[cfg(any(test, feature = "test-utils"))]
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error[E0432]: unresolved import `virtio_queue::mock`
   --> vhost-device-scsi/src/virtio.rs:318:45
    |
318 |     use virtio_queue::{desc::RawDescriptor, mock::MockSplitQueue};
    |                                             ^^^^ could not find `mock` in `virtio_queue`
    |
note: found an item that was configured out
   --> .cargo/registry/src/index.crates.io-1949cf8c6b5b557f/virtio-queue-0.16.0/src/lib.rs:34:9
    |
34  | pub mod mock;
    |         ^^^^
note: the item is gated here
   --> .cargo/registry/src/index.crates.io-1949cf8c6b5b557f/virtio-queue-0.16.0/src/lib.rs:33:1
    |
33  | #[cfg(any(test, feature = "test-utils"))]
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

For more information about this error, try `rustc --explain E0432`.
error: could not compile `vhost-device-scsi` (bin "vhost-device-scsi" test) due to 2 previous errors

@stefano-garzarella
Copy link
Member

@epilys I'm pretty sure I checked the CI results also to check staging devices, and it was all green, so now I'm worried about what happened...

epilys added a commit to epilys/vhost-device that referenced this pull request Jul 8, 2025
Seems like since at least PR rust-vmm#849 compilation for scsi in test targets
was broken, so fix it.

Signed-off-by: Manos Pitsidianakis <[email protected]>
@epilys epilys mentioned this pull request Jul 8, 2025
4 tasks
@epilys
Copy link
Member

epilys commented Jul 8, 2025

@stefano-garzarella I've no idea either, it seems only the DCO check ran? I always check too but maybe we both missed it this time :/ Anyway, I pushed a fix in #850

@stefano-garzarella
Copy link
Member

@epilys but it's strange that CI on current main is green, no?

@epilys
Copy link
Member

epilys commented Jul 8, 2025

@stefano-garzarella yep, the current green status is for pr #848. It seems buildkite wasn't triggered at all for the #849 PR.

@epilys
Copy link
Member

epilys commented Jul 8, 2025

(If you click the green checkmark and go on buildkite, you can see the PR that triggered that specific run)

@stefano-garzarella
Copy link
Member

@epilys yep, but the build is done on the main branch after the merge (I guess), indeed it refers to 79a8bc6

I'm just worried that our CI is not triggering that issue...

@epilys
Copy link
Member

epilys commented Jul 8, 2025

Can we trigger a manual run before merging the fix? (FWIW I checked that it fails before and runs successfully after, locally)

@stefano-garzarella
Copy link
Member

@epilys I pushed #851 just to play with it, and it seems only DCO is failing (some CI tasks still running)

@epilys
Copy link
Member

epilys commented Jul 8, 2025

@stefano-garzarella now I'm more confused. Can you see the compilation failure on your end on main? Maybe it was a problem on my side? (No idea why though)

@stefano-garzarella
Copy link
Member

@epilys yep, failing also here, there should be something in our CI:

$ cargo test -p vhost-device-scsi
   Compiling vhost-device-scsi v0.1.0 (/home/stefano/repos/vhost-device/vhost-device-scsi)
error[E0432]: unresolved import `virtio_queue::mock`
   --> vhost-device-scsi/src/vhu_scsi.rs:339:9
    |
339 |         mock::MockSplitQueue,
    |         ^^^^ could not find `mock` in `virtio_queue`
    |
note: found an item that was configured out
   --> /home/stefano/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/virtio-queue-0.16.0/src/lib.rs:34:9
    |
34  | pub mod mock;
    |         ^^^^
note: the item is gated here
   --> /home/stefano/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/virtio-queue-0.16.0/src/lib.rs:33:1
    |
33  | #[cfg(any(test, feature = "test-utils"))]
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error[E0432]: unresolved import `virtio_queue::mock`
   --> vhost-device-scsi/src/virtio.rs:318:45
    |
318 |     use virtio_queue::{desc::RawDescriptor, mock::MockSplitQueue};
    |                                             ^^^^ could not find `mock` in `virtio_queue`
    |
note: found an item that was configured out
   --> /home/stefano/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/virtio-queue-0.16.0/src/lib.rs:34:9
    |
34  | pub mod mock;
    |         ^^^^
note: the item is gated here
   --> /home/stefano/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/virtio-queue-0.16.0/src/lib.rs:33:1
    |
33  | #[cfg(any(test, feature = "test-utils"))]
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

For more information about this error, try `rustc --explain E0432`.
error: could not compile `vhost-device-scsi` (bin "vhost-device-scsi" test) due to 2 previous errors

@epilys
Copy link
Member

epilys commented Jul 8, 2025

Oooh I think I know why. CI runs tests with --all-features --workspace 🤦 And because other crates have dev-dependency of virtio-queue with test-utils feature enabled, the feature gets used/reconciled for scsi as well. But if you run cargo run --all-features only on scsi subdirectory, the feature does not get selected.

@stefano-garzarella
Copy link
Member

@epilys yeah, it's the case, I was just installing libgpiod to run all tests...
So your fix should be merged in any case, but it was pre-existing, right?

@epilys
Copy link
Member

epilys commented Jul 8, 2025

Yep, pre-existing, not related to this PR after all.

@epilys
Copy link
Member

epilys commented Jul 8, 2025

Weird that the CI was skipped for this PR though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants