feat(ts): almost enable TypeScript in the playground #5384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This issue has been linked to a new work item: W-18762897 |
jmsjtu
reviewed
Jun 11, 2025
| @@ -15,6 +16,7 @@ export default (args) => { | |||
| }, | |||
|
|
|||
| plugins: [ | |||
| // typescript(), // Only required for TypeScript projects | |||
There was a problem hiding this comment.
Would it cause issues if we just left it on?
Does it cause issues for .js only components?
There was a problem hiding this comment.
It shouldn't cause issues, but I wanted to be sure that we're sticking to only the truly minimal playground for the default use case.
divmain
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
We want the playground to be minimal, but we also want it to be easy to have a minimal TypeScript playground. This PR adds the necessary bits to support TS, but comments them out by default.
Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
GUS work item