Skip to content

feat(ts): almost enable TypeScript in the playground #5384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2025
Merged

Conversation

wjhsf
Copy link
Collaborator

@wjhsf wjhsf commented Jun 11, 2025

Details

We want the playground to be minimal, but we also want it to be easy to have a minimal TypeScript playground. This PR adds the necessary bits to support TS, but comments them out by default.

Does this pull request introduce a breaking change?

  • 😮‍💨 No, it does not introduce a breaking change.
  • 💔 Yes, it does introduce a breaking change.

Does this pull request introduce an observable change?

  • 🤞 No, it does not introduce an observable change.
  • 🔬 Yes, it does include an observable change.

GUS work item

@wjhsf wjhsf requested a review from a team as a code owner June 11, 2025 20:18
Copy link

git2gus bot commented Jun 11, 2025

This issue has been linked to a new work item: W-18762897

@@ -15,6 +16,7 @@ export default (args) => {
},

plugins: [
// typescript(), // Only required for TypeScript projects
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it cause issues if we just left it on?

Does it cause issues for .js only components?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It shouldn't cause issues, but I wanted to be sure that we're sticking to only the truly minimal playground for the default use case.

@wjhsf wjhsf merged commit d867684 into master Jun 11, 2025
6 checks passed
@wjhsf wjhsf deleted the wjh/ts-playground branch June 11, 2025 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants