Skip to content

Re-enable PluginCoverageScalaJsTest, fix dangling UndefinedParam bug #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jun 3, 2022
Merged

Re-enable PluginCoverageScalaJsTest, fix dangling UndefinedParam bug #464

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
585ed58
Try re-enabling PluginCoverageScalaJsTest
armanbilge May 29, 2022
61be139
ScoverageCompiler refactoring to support SJS
armanbilge May 31, 2022
e5bbd14
Scala.js test is working again
armanbilge May 31, 2022
8da1f01
Remove unneeded dep
armanbilge May 31, 2022
66de565
Try adding buildInfo to root
armanbilge May 31, 2022
c13a068
Set crossScalaVersions for buildinfo project
armanbilge May 31, 2022
0c69003
Revert "Remove unneeded dep"
armanbilge May 31, 2022
7b9212b
Add another sjs test dep
armanbilge May 31, 2022
d8d2a1c
plugin also depends on runtimeJS for tests
armanbilge May 31, 2022
aa833a4
Actually enable the sjs compiler plugin :)
armanbilge May 31, 2022
09f3673
Fix expected measured statements 4 -> 2
armanbilge May 31, 2022
695ce2d
Only catch non-fatals
armanbilge May 31, 2022
775828f
Make isScalaJsEnabled a lazy val
armanbilge May 31, 2022
96136e5
I think these deps are unneeded now
armanbilge May 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Try adding buildInfo to root
  • Loading branch information
@armanbilge
armanbilge committed May 31, 2022
commit 66de56527e95969d09065e56b4f63b2c4f4b13a9
3 changes: 2 additions & 1 deletion build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,8 @@ lazy val root = Project("scalac-scoverage", file("."))
runtimeJSDOMTest,
reporter,
domain,
serializer
serializer,
buildInfo
)

lazy val runtime = CrossProject(
Expand Down