Skip to content

feat: feynman base fee #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: scroll
Choose a base branch
from
Open

feat: feynman base fee #273

wants to merge 3 commits into from

Conversation

greged93
Copy link
Collaborator

@greged93 greged93 commented Jul 4, 2025

Adds the Feynman L2 base fee computation to Reth and introduces it into the transaction pool.

Copy link

codspeed-hq bot commented Jul 4, 2025

CodSpeed Performance Report

Merging #273 will not alter performance

Comparing feat/feynman-base-fee (6506202) with scroll (766dd27)

Summary

✅ 77 untouched benchmarks

Comment on lines +38 to +39
// TODO: should we get the pool base fee in the case where the transaction is a pending
// transaction here?
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is one of the points that I'm not sure about: should the base fee from the transaction pool be fetched and used here?

For context, this type is used in the RpcConverter and builds a RPC transaction from a recovered tx and the scroll transaction info (which contains the L1 fee and the block context info). For now, afaiu, the RpcConverter uses empty block context for pending pool transaction (see here) but from what I understand in l2geth, the pending base fee is used to compute the effective_gas_price for pool transactions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant