-
Notifications
You must be signed in to change notification settings - Fork 624
feat: upgrade intermedidate #1687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThis update adds the Rust nightly version Changes
Possibly related PRs
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
build/dockerfiles/coordinator-api.Dockerfile (1)
2-2
: Hard-coded tag couples Go & Rust upgrades – extract to ARG to keep future bumps trivialEmbedding the full tag string forces every future version bump to touch every stage line.
Consider:-FROM scrolltech/cuda-go-rust-builder:cuda-11.7.1-go-1.22.12-rust-nightly-2025-02-14 as chef +ARG BASE_TAG="cuda-11.7.1-go-1.22.12-rust-nightly-2025-02-14" +FROM scrolltech/cuda-go-rust-builder:${BASE_TAG} as chefand reuse
${BASE_TAG}
in stagebase
. This keeps the file DRY and reduces merge conflicts when versions change again.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/intermediate-docker.yml
(1 hunks)build/dockerfiles/coordinator-api.Dockerfile
(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: tests
🔇 Additional comments (2)
.github/workflows/intermediate-docker.yml (1)
24-29
: New Rust nightly added – please verify image availability & consider bumping the default
nightly-2025-02-14
is now selectable, but the default remainsnightly-2023-12-03
.
- Ensure the corresponding intermediate images are already pushed (
scrolltech/*:rust-nightly-2025-02-14
, etc.); otherwise CI builds depending on the new Dockerfile will fail.- If the intention is to standardise on the newer toolchain, update
default:
to the same version to avoid accidental drift.build/dockerfiles/coordinator-api.Dockerfile (1)
28-28
: Verify that the new base image is present in the registry before merging
scrolltech/cuda-go-rust-builder:cuda-11.7.1-go-1.22.12-rust-nightly-2025-02-14
must exist prior to buildingcoordinator-api
, otherwise CI will break early.
Confirm the intermediate-docker workflow publishes this tag or push it manually first.
Purpose or design rationale of this PR
Describe your change. Make sure to answer these three questions: What does this PR do? Why does it do it? How does it do it?
PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
Deployment tag versioning
Has
tag
incommon/version.go
been updated or have you addedbump-version
label to this PR?Breaking change label
Does this PR have the
breaking-change
label?Summary by CodeRabbit