fix(bridge-history): commit batch txns and blobs fetching #1689
Conversation
WalkthroughThe changes update the version tag to "v4.5.26" and enhance the Changes
Sequence Diagram(s)sequenceDiagram
participant Caller
participant L1EventParser
participant RPCClient
participant BlobProcessor
Caller->>L1EventParser: ParseL1BatchEventLogs(logs)
loop For each log
L1EventParser->>L1EventParser: Check cached transaction
alt Cache miss
L1EventParser->>RPCClient: Fetch transaction (10s timeout)
RPCClient-->>L1EventParser: Transaction data
end
L1EventParser->>BlobProcessor: Process blob (20s timeout)
BlobProcessor-->>L1EventParser: Blob data
end
L1EventParser-->>Caller: Parsed events
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 golangci-lint (1.64.8)level=warning msg="[runner] Can't run linter goanalysis_metalinter: buildir: failed to load package zstd: could not load export data: no export data for "github.com/scroll-tech/da-codec/encoding/zstd"" 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🧰 Additional context used🧠 Learnings (1)bridge-history-api/internal/logic/l1_event_parser.go (1)⏰ Context from checks skipped due to timeout of 90000ms (3)
🔇 Additional comments (6)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1689 +/- ##
===========================================
- Coverage 39.86% 39.81% -0.06%
===========================================
Files 236 236
Lines 18808 18832 +24
===========================================
Hits 7498 7498
- Misses 10575 10599 +24
Partials 735 735
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
colinlyguo
deleted the
fix-bridge-history-commit-batch-txns-and-blobs-fetching
branch
Purpose or design rationale of this PR
This PR adds a timeout when fetching commit batch txns and blobs, it also avoids fetching the same transaction multiple times.
This PR adds two debug logs for easier debugging.
PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
Deployment tag versioning
Has
tagincommon/version.gobeen updated or have you addedbump-versionlabel to this PR?Breaking change label
Does this PR have the
breaking-changelabel?Summary by CodeRabbit
Improvements
Chores