Skip to content

Adapt to MongoDB 2.4 changes #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2013
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions mongodb.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

import collectd
from pymongo import Connection
from distutils.version import StrictVersion as V


class MongoDB(object):
Expand Down Expand Up @@ -41,6 +42,9 @@ def do_server_status(self):
db.authenticate(self.mongo_user, self.mongo_password)
server_status = db.command('serverStatus')

version = server_status['version']
at_least_2_4 = V(version) >= V('2.4.0')

# operations
for k, v in server_status['opcounters'].items():
self.submit('total_operations', k, v)
Expand All @@ -63,23 +67,24 @@ def do_server_status(self):
self.lockTotalTime = server_status['globalLock']['totalTime']
self.lockTime = server_status['globalLock']['lockTime']


# indexes
accesses = None
misses = None
index_counters = server_status['indexCounters'] if at_least_2_4 else server_status['indexCounters']['btree']

if self.accesses is not None:
accesses = server_status['indexCounters']['btree']['accesses'] - self.accesses
accesses = index_counters['accesses'] - self.accesses
if accesses < 0:
accesses = None
misses = (server_status['indexCounters']['btree']['misses'] or 0) - (self.misses or 0)
misses = (index_counters['misses'] or 0) - (self.misses or 0)
if misses < 0:
misses = None
if accesses and misses is not None:
self.submit('cache_ratio', 'cache_misses', int(misses * 100 / float(accesses)))
else:
self.submit('cache_ratio', 'cache_misses', 0)
self.accesses = server_status['indexCounters']['btree']['accesses']
self.misses = server_status['indexCounters']['btree']['misses']
self.accesses = index_counters['accesses']
self.misses = index_counters['misses']

for mongo_db in self.mongo_db:
db = con[mongo_db]
Expand Down