Skip to content

Code improvement, fixed staticcheck and linter warnings #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 46 commits into
base: master
Choose a base branch
from
Open

Code improvement, fixed staticcheck and linter warnings #32

wants to merge 46 commits into from

Conversation

pilinux
Copy link

@pilinux pilinux commented Dec 5, 2022

⚡ dependency management using go module (go version v1.19+)
⚡ fixed: go-staticcheck warnings
⚡ fixed: linter warnings
⚡ functions to generate recovery codes
⚡ lots of code optimization

pilinux and others added 30 commits December 4, 2022 14:40
@pilinux
chore: dependency management using go module
ca97c8f
@pilinux
fix: go-staticcheck warnings
d32b03f 
- error strings should not be capitalized
- redundant break statement
- possible nil pointer dereference
@pilinux
fix: linter warnings
d39cdc9 
- don't use underscores in Go names
- missing package comment
- missing comment on exported types
- missing comment on exported functions
- missing comment on exported methods
@pilinux
chore: call Secret function
bb5e1f2
@pilinux
chore: error var for token mismatch
f68757b
@pilinux
chore: reduce calling validBackOffTime
2ef3a10
@pilinux
feat: functions to generate recovery codes
4317c14
@pilinux
feat: get the hash function and number of digits
a440d35
@pilinux
feat: expose URL
a08c6c3
@pilinux
Create codeql.yml
09cca30
@pilinux
Create dependabot.yml
7338982
@pilinux
chore: github action files added
f9ee9ac
@pilinux
Update README.md
b99c334
@pilinux
updated dependencies
16866b8
@pilinux
typo fix + prettify
9f9b444
@pilinux
ci: update github actions
aeb0b66
@pilinux
replace cryptoengine package
14b248e 
`github.com/sec51/cryptoengine` -> `github.com/pilinux/cryptoengine`
@pilinux
optimised for go pkg docs
acadc1c
@dependabot
Bump actions/setup-go from 4 to 5 (#8)
c53a307 
Bumps [actions/setup-go](https://github.com/actions/setup-go) from 4 to 5.
- [Release notes](https://github.com/actions/setup-go/releases)
- [Commits](actions/setup-go@v4...v5)

---
updated-dependencies:
- dependency-name: actions/setup-go
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump github/codeql-action from 2 to 3 (#9)
a830763 
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2 to 3.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@v2...v3)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump golangci/golangci-lint-action from 3 to 4 (#16)
d8deeb2 
Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 3 to 4.
- [Release notes](https://github.com/golangci/golangci-lint-action/releases)
- [Commits](golangci/golangci-lint-action@v3...v4)

---
updated-dependencies:
- dependency-name: golangci/golangci-lint-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump actions/cache from 3.3.2 to 4.0.2 (#19)
359c2cb 
Bumps [actions/cache](https://github.com/actions/cache) from 3.3.2 to 4.0.2.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](actions/cache@v3.3.2...v4.0.2)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump github.com/pilinux/cryptoengine from 0.1.1 to 0.1.2 (#18)
597c171 
Bumps [github.com/pilinux/cryptoengine](https://github.com/pilinux/cryptoengine) from 0.1.1 to 0.1.2.
- [Release notes](https://github.com/pilinux/cryptoengine/releases)
- [Changelog](https://github.com/pilinux/cryptoengine/blob/main/CHANGELOG.md)
- [Commits](pilinux/cryptoengine@v0.1.1...v0.1.2)

---
updated-dependencies:
- dependency-name: github.com/pilinux/cryptoengine
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump golang.org/x/sync from 0.5.0 to 0.6.0 (#11)
c3ca413 
Bumps [golang.org/x/sync](https://github.com/golang/sync) from 0.5.0 to 0.6.0.
- [Commits](golang/sync@v0.5.0...v0.6.0)

---
updated-dependencies:
- dependency-name: golang.org/x/sync
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump golangci/golangci-lint-action from 4 to 5 (#22)
1021acb 
Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 4 to 5.
- [Release notes](https://github.com/golangci/golangci-lint-action/releases)
- [Commits](golangci/golangci-lint-action@v4...v5)

---
updated-dependencies:
- dependency-name: golangci/golangci-lint-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@pilinux
ci: actions/cache v4.0.2 -> v4
5e3d264
@dependabot
Bump github.com/pilinux/cryptoengine from 0.1.2 to 0.1.3 (#23)
a2df29d 
Bumps [github.com/pilinux/cryptoengine](https://github.com/pilinux/cryptoengine) from 0.1.2 to 0.1.3.
- [Release notes](https://github.com/pilinux/cryptoengine/releases)
- [Changelog](https://github.com/pilinux/cryptoengine/blob/main/CHANGELOG.md)
- [Commits](pilinux/cryptoengine@v0.1.2...v0.1.3)

---
updated-dependencies:
- dependency-name: github.com/pilinux/cryptoengine
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump golang.org/x/sync from 0.6.0 to 0.7.0 (#21)
3ab8088 
Bumps [golang.org/x/sync](https://github.com/golang/sync) from 0.6.0 to 0.7.0.
- [Commits](golang/sync@v0.6.0...v0.7.0)

---
updated-dependencies:
- dependency-name: golang.org/x/sync
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump golangci/golangci-lint-action from 5 to 6 (#24)
e8be9f8 
Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 5 to 6.
- [Release notes](https://github.com/golangci/golangci-lint-action/releases)
- [Commits](golangci/golangci-lint-action@v5...v6)

---
updated-dependencies:
- dependency-name: golangci/golangci-lint-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump golang.org/x/crypto from 0.22.0 to 0.23.0 (#25)
eb0797b 
Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.22.0 to 0.23.0.
- [Commits](golang/crypto@v0.22.0...v0.23.0)

---
updated-dependencies:
- dependency-name: golang.org/x/crypto
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
dependabot bot and others added 16 commits May 17, 2024 11:21
@dependabot
Bump github.com/pilinux/cryptoengine from 0.1.3 to 0.1.4 (#26)
77280a4 
Bumps [github.com/pilinux/cryptoengine](https://github.com/pilinux/cryptoengine) from 0.1.3 to 0.1.4.
- [Release notes](https://github.com/pilinux/cryptoengine/releases)
- [Changelog](https://github.com/pilinux/cryptoengine/blob/main/CHANGELOG.md)
- [Commits](pilinux/cryptoengine@v0.1.3...v0.1.4)

---
updated-dependencies:
- dependency-name: github.com/pilinux/cryptoengine
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump github.com/pilinux/cryptoengine from 0.1.4 to 0.1.5 (#28)
47f125e 
Bumps [github.com/pilinux/cryptoengine](https://github.com/pilinux/cryptoengine) from 0.1.4 to 0.1.5.
- [Release notes](https://github.com/pilinux/cryptoengine/releases)
- [Changelog](https://github.com/pilinux/cryptoengine/blob/main/CHANGELOG.md)
- [Commits](pilinux/cryptoengine@v0.1.4...v0.1.5)

---
updated-dependencies:
- dependency-name: github.com/pilinux/cryptoengine
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@pilinux
set minimum required go version 1.20
2e8fb01
@dependabot
Bump github.com/pilinux/cryptoengine from 0.1.6 to 0.1.7 (#33)
263811d 
Bumps [github.com/pilinux/cryptoengine](https://github.com/pilinux/cryptoengine) from 0.1.6 to 0.1.7.
- [Release notes](https://github.com/pilinux/cryptoengine/releases)
- [Changelog](https://github.com/pilinux/cryptoengine/blob/main/CHANGELOG.md)
- [Commits](pilinux/cryptoengine@v0.1.6...v0.1.7)

---
updated-dependencies:
- dependency-name: github.com/pilinux/cryptoengine
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump golang.org/x/crypto from 0.27.0 to 0.30.0 (#38)
5b212b5 
Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.27.0 to 0.30.0.
- [Commits](golang/crypto@v0.27.0...v0.30.0)

---
updated-dependencies:
- dependency-name: golang.org/x/crypto
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump golang.org/x/sync from 0.8.0 to 0.10.0 (#37)
3d4db00 
Bumps [golang.org/x/sync](https://github.com/golang/sync) from 0.8.0 to 0.10.0.
- [Commits](golang/sync@v0.8.0...v0.10.0)

---
updated-dependencies:
- dependency-name: golang.org/x/sync
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump github.com/pilinux/cryptoengine from 0.1.7 to 0.1.9 (#41)
7ed5652 
Bumps [github.com/pilinux/cryptoengine](https://github.com/pilinux/cryptoengine) from 0.1.7 to 0.1.9.
- [Release notes](https://github.com/pilinux/cryptoengine/releases)
- [Changelog](https://github.com/pilinux/cryptoengine/blob/main/CHANGELOG.md)
- [Commits](pilinux/cryptoengine@v0.1.7...v0.1.9)

---
updated-dependencies:
- dependency-name: github.com/pilinux/cryptoengine
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump golang.org/x/crypto from 0.31.0 to 0.32.0 (#42)
3930f04 
Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.31.0 to 0.32.0.
- [Commits](golang/crypto@v0.31.0...v0.32.0)

---
updated-dependencies:
- dependency-name: golang.org/x/crypto
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump golang.org/x/sync from 0.10.0 to 0.11.0 (#43)
594f4f4 
Bumps [golang.org/x/sync](https://github.com/golang/sync) from 0.10.0 to 0.11.0.
- [Commits](golang/sync@v0.10.0...v0.11.0)

---
updated-dependencies:
- dependency-name: golang.org/x/sync
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump golang.org/x/crypto from 0.32.0 to 0.33.0 (#44)
c0670cb 
Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.32.0 to 0.33.0.
- [Commits](golang/crypto@v0.32.0...v0.33.0)

---
updated-dependencies:
- dependency-name: golang.org/x/crypto
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@pilinux
set minimum required go version 1.23.0
77e3019 
bumped github.com/pilinux/cryptoengine to 0.1.10
bumped golang.org/x/sync to 0.13.0
bumped golang.org/x/crypto to 0.37.0
bumped golang.org/x/sys to 0.32.0
@dependabot
Bump golang.org/x/crypto from 0.37.0 to 0.38.0 (#54)
e8667b6 
Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.37.0 to 0.38.0.
- [Commits](golang/crypto@v0.37.0...v0.38.0)

---
updated-dependencies:
- dependency-name: golang.org/x/crypto
  dependency-version: 0.38.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump golang.org/x/sync from 0.13.0 to 0.14.0 (#53)
f634e5c 
Bumps [golang.org/x/sync](https://github.com/golang/sync) from 0.13.0 to 0.14.0.
- [Commits](golang/sync@v0.13.0...v0.14.0)

---
updated-dependencies:
- dependency-name: golang.org/x/sync
  dependency-version: 0.14.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@pilinux
ci: bump golangci-lint-action from v7 to v8
2fef7c2
@dependabot
Bump golang.org/x/crypto from 0.38.0 to 0.39.0 (#56)
f67eef0 
Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.38.0 to 0.39.0.
- [Commits](golang/crypto@v0.38.0...v0.39.0)

---
updated-dependencies:
- dependency-name: golang.org/x/crypto
  dependency-version: 0.39.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump golang.org/x/sync from 0.14.0 to 0.15.0 (#55)
fd5ea64 
Bumps [golang.org/x/sync](https://github.com/golang/sync) from 0.14.0 to 0.15.0.
- [Commits](golang/sync@v0.14.0...v0.15.0)

---
updated-dependencies:
- dependency-name: golang.org/x/sync
  dependency-version: 0.15.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pilinux