Skip to content

Update Phasar Config #752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 5, 2025
Merged

Update Phasar Config #752

merged 6 commits into from
Mar 5, 2025

Conversation

fabianbs96
Copy link
Member

Do not mention phasar's version at too many different places. Derive it from a single cmake variable.

Also, cleanup PhasarConfig a bit.

@fabianbs96 fabianbs96 requested a review from MMory as a code owner February 22, 2025 14:34
@fabianbs96 fabianbs96 added this to the March Release 2025 milestone Feb 26, 2025
sritejakv
sritejakv approved these changes Mar 5, 2025
View reviewed changes
Copy link
Collaborator

@sritejakv sritejakv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@fabianbs96 fabianbs96 merged commit 332509b into development Mar 5, 2025
8 checks passed
@fabianbs96 fabianbs96 deleted the f-UpdatePhasarConfig branch March 5, 2025 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sritejakv sritejakv sritejakv approved these changes

@MMory MMory Awaiting requested review from MMory MMory is a code owner

Assignees
No one assigned
Labels
cleanup
Projects
None yet
Milestone
March Release 2025
Development

Successfully merging this pull request may close these issues.
2 participants
@fabianbs96 @sritejakv