Make headerAuthentication validation function async #581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ziegler-daniel
force-pushed
the
feature/make_headerAuthentication_validation_function_async
branch
from
9ce16b0 to
abb7403
Compare
adityamatt
reviewed
May 30, 2025
| [ | ||
| headerAuthentication({ | ||
| validateUsingHeaderFn: async (headers: Headers) => { | ||
| return headers.get('my-authentication-header') === 'authenticated'; |
There was a problem hiding this comment.
I would do a an await here to make sure the async-ness is actually tested.
await some mock promise that resolves to true or false
adityamatt
approved these changes
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue: #576