Skip to content

Java 11: bring jacoco-maven-plugin up to current #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

kebeda
Copy link
Contributor

@kebeda kebeda commented Sep 17, 2019

Fixes #118

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

This change will allow mvn test to succeed when run under
a Java 11 JVM/javac.

It resolves it by updating the jacoco-maven-plugin to a version
that can run in this configuration.

This change will allow `mvn test` to succeed when run under
a Java 11 JVM/javac.

It resolves it by updating the jacoco-maven-plugin to a version
that can run in this configuration.
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Sep 17, 2019
@kebeda
Copy link
Contributor Author

kebeda commented Sep 17, 2019

Didn't check the last 3 checkboxes on the PR description because,

  • The existing tests cover this
  • No user-visible changes are in this PR
  • There was no code changed, hence no comment needed

@thinkingserious thinkingserious added difficulty: easy fix is easy in difficulty status: duplicate duplicate issue type: bug bug in the library and removed status: code review request requesting a community code review or review from Twilio labels Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy fix is easy in difficulty status: duplicate duplicate issue type: bug bug in the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to test under Java 11
2 participants