Refactor/compile components modernization to #244 #457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removes version number and compilation counter from filenames for better readability - Uses moment.js for consistent timestamp formatting - Implements German date format (DD-MM-YYYY) - Adds hours, minutes, and seconds to the timestamp - Simplifies filename structure for better usability Example of new filename: 'my-project_16-04-2024_14_03_41.bin'
- Convert Compile component from class to functional component - Implement useCompile custom hook for better state management - Add timestamp functionality to file downloads - Improve error handling and UI feedback - Add multi-language support for tooltips - Remove redundant state management - Update file naming convention with whitespace detection - Add platform-specific compilation handling (esp32 vs mcu) - Integrate moment.js for consistent date formatting - Remove deprecated dialog logic - Improve code organization and maintainability BREAKING CHANGE: Compile.js is removed in favor of Compile.jsx
Tests
Github Test Reporter by CTRF 💚 |
Package Management: - Remove yarn.lock file to prevent package manager conflicts - Add yarn.lock to .gitignore to prevent future conflicts - Clean up yarn-specific dependencies and configurations - Ensure consistent package management with npm Compilation Dialog: - Change timestamp format from DD-MM-YYYY_HH_mm_ss to YYYY-MM-DD-HH-mm-ss - Reorder filename components to put timestamp before cleanName - Update both downloadUrl and download filename to maintain consistency This commit standardizes the package management approach by removing Yarn-related files and improves the file naming convention in the compilation dialog by using a more standard ISO-like date format and placing the timestamp before the filename for better sorting and organization of downloaded files.
Tests
Github Test Reporter by CTRF 💚 |
|
Der Issue (#244) sollte darum gehen, Dateien die runtergeladen werden anders zu benennen. Nicht eine neue useCompile Hook oder andere "code organization and maintainability" Aufgaben. Bitte passe die PR entsprechened an oder öffne eine neue |
georgi-s
force-pushed
the
fix/backpack-usage-#346
branch
from
5f68eb8 to
dab5f29
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Compile.js is removed in favor of Compile.jsx