Skip to content

Feat/add confirmation of successful buffering in backpack #322 #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: refactor/compile-components-modernization
Choose a base branch
from

Conversation

georgi-s
Copy link
Contributor

– Add MUI alerts for various backpack actions:

  • Success message when adding blocks
  • Info message when removing blocks
  • Warning for Arduino function blocks
  • Confirmation when emptying the backpack

– Integrate translation system:

  • Use Blockly.Msg for multilingual support
  • Add new translation keys:
    – ARDUINO_FUNCTION_BLOCK_WARNING
    – ARDUINO_FUNCTION_BLOCKS_SKIPPED
    – BLOCKS_ADDED_TO_BACKPACK
    – BLOCKS_PASTED_FROM_BACKPACK

– Improve user feedback:

  • Show block count for bulk operations
  • Use different alert types (success, warning, info)
  • Auto-hide after 3 seconds
  • Centered position at the bottom of the screen

– Technical improvements:

  • Correct event handler integration
  • Clean code structure
  • Error handling for Arduino function blocks

Closes #322

- Test now searches for both possible reset button texts
- Supports both English ("Reset code") and German ("Code zurücksetzen") translations
- Uses regular expressions for flexible text searches
- Improves the robustness of the test across different language settings
- Test now searches for both possible reset button texts
- Supports both English ("Reset code") and German ("Code zurücksetzen") translations
- Uses regular expressions for flexible text searches
- Improves the robustness of the test across different language settings
@georgi-s georgi-s changed the base branch from main to development April 23, 2025 15:16
Copy link
Contributor

@Thiemann96 Thiemann96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work

bitte noch texte updaten dann ists 👍

@@ -264,4 +264,14 @@ export const TRANSLATIONS = {
senseBox_watertemperature: "Wassertemperatur",
senseBox_watertemperature_tooltip:
"Das Wasserthermometer gibt Temperatur in Grad Celsius aus. Schließe den Sensor an einen der 6 Anschlüsse des One-Wire Adapters an und schließe dann den One-Wire Adapter an einen der 3 digital/analog Ports der senseBox an und wähle den Port im Block aus. Wenn du nur ein Thermometer am One-Wire Adapter angeschlossen hast, dann belasse den Index bei 0. Jedes weitere angeschlossene Thermometer kann entsprechend mit einem um 1 erhöhten Index angesprochen werden. Es kommt dabei nicht darauf an, an welchem Anschluss des Adapters die Thermometer angeschlossen werden.",
EMPTY_BACKPACK: "Rucksack leeren",
REMOVE_FROM_BACKPACK: "Aus Rucksack entfernen",
COPY_TO_BACKPACK: "In Rucksack kopieren",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besser: "Block im Rucksack abgelegt" als Meldung wenn ich einen Block im Rucksack abgelegt habe. Die jetzigen Meldungen machen (noch) nicht so viel Sinn 😅

"The water thermometer outputs temperature in degrees Celsius. Connect the sensor to one of the 6 ports of the One-Wire adapter and then connect the One-Wire adapter to one of the 3 digital/analog ports of the senseBox and select the port in the block. If you only have one thermometer connected to the One-Wire adapter, then leave the index at 0. Each additional connected thermometer can be addressed with an index increased by 1. It does not matter at which port of the adapter the thermometers are connected.",
EMPTY_BACKPACK: "Empty Backpack",
REMOVE_FROM_BACKPACK: "Remove from Backpack",
COPY_TO_BACKPACK: "Copy to Backpack",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bitte auch im Englischen kurz die Texte überarbeiten

@@ -18,58 +19,313 @@ class BlocklyWindow extends Component {
constructor(props) {
super(props);
this.simpleWorkspace = React.createRef();
this.backpackBlockPosition = null;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scheinen mir die gleicehn änderungen wie in #453 zu sein.

Beim nächsten Mal kannst du einen neuen Branch von z.B. fix/backpack-usage-#346 erstellen und danach den neuen Branch wieder in fix/backpack-usage-#346 mergen.

@georgi-s georgi-s changed the base branch from development to refactor/compile-components-modernization May 15, 2025 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bestätigung bei erfolgreicher Zwischenspeicherung im Rucksack
2 participants