Skip to content

Chore/prettier check #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: feat/add-confirmation-of-successful-buffering-in-backpack-#322
Choose a base branch
from

Conversation

georgi-s
Copy link
Contributor

style: format codebase with Prettier

  • Format 15 files according to Prettier standards
  • Improve code readability and consistency
  • Standardize code style across the project

Files formatted:

  • src/App.jsx
  • src/components/Blockly/blocks/procedures.js
  • src/components/Blockly/blocks/sensebox-led.js
  • src/components/Blockly/generator/sensebox-display.js
  • src/components/Blockly/generator/variables.js
  • src/components/Blockly/msg/de/sensebox-led.js
  • src/components/Blockly/msg/de/sensebox-osem.js
  • src/components/Blockly/msg/en/sensebox-led.js
  • src/components/CodeEditor/Sidebar.jsx
  • src/components/Settings/CompilerSelector.jsx
  • src/components/TooltipViewer.jsx
  • src/components/Workspace/Compile.jsx
  • src/hooks/useCompile.js
  • src/index.css
  • src/serviceWorker.js

This commit ensures consistent code formatting across the project
using Prettier's default configuration, improving code readability
and maintainability.

ammar450 and others added 9 commits February 8, 2025 03:58
- Removes version number and compilation counter from filenames for better readability
- Uses moment.js for consistent timestamp formatting
- Implements German date format (DD-MM-YYYY)
- Adds hours, minutes, and seconds to the timestamp
- Simplifies filename structure for better usability

Example of new filename: 'my-project_16-04-2024_14_03_41.bin'
- Convert Compile component from class to functional component
- Implement useCompile custom hook for better state management
- Add timestamp functionality to file downloads
- Improve error handling and UI feedback
- Add multi-language support for tooltips
- Remove redundant state management
- Update file naming convention with whitespace detection
- Add platform-specific compilation handling (esp32 vs mcu)
- Integrate moment.js for consistent date formatting
- Remove deprecated dialog logic
- Improve code organization and maintainability

BREAKING CHANGE: Compile.js is removed in favor of Compile.jsx
Package Management:
- Remove yarn.lock file to prevent package manager conflicts
- Add yarn.lock to .gitignore to prevent future conflicts
- Clean up yarn-specific dependencies and configurations
- Ensure consistent package management with npm

Compilation Dialog:
- Change timestamp format from DD-MM-YYYY_HH_mm_ss to YYYY-MM-DD-HH-mm-ss
- Reorder filename components to put timestamp before cleanName
- Update both downloadUrl and download filename to maintain consistency

This commit standardizes the package management approach by removing
Yarn-related files and improves the file naming convention in the
compilation dialog by using a more standard ISO-like date format and
placing the timestamp before the filename for better sorting and
organization of downloaded files.
Copy link

Tests

Test Name Status Flaky Duration
Blockly Editor Page Tests [Blockly] visits the editor page 947ms
Blockly Editor Page Tests [Blockly] visits the tutorial page 181ms
Blockly Editor Page Tests [Blockly] visits the gallery page 140ms
Blockly Editor Page Tests [Blockly] visits the faq page 131ms
Blockly Editor Page Tests [Blockly] visits the settings page 135ms
Blockly Editor Page Tests [Blockly] visits the login page 134ms
Blockly Editor Page Tests [Blockly] navigates to tutorial and back 13.9s
Blockly Editor Page Tests [Blockly] selects senseBox ESP 696ms
Blockly Editor Page Tests [Blockly] selects senseBox MCU 710ms
Blockly Editor Page Tests [Blockly] selects senseBox Mini 731ms
Blockly Editor Page Tests [Blockly] compiles code 30.9s
Code Editor Page Tests [CodeEditor] visits the code editor page 1.3s
Code Editor Page Tests [CodeEditor] selects senseBox ESP 448ms
Code Editor Page Tests [CodeEditor] compiles code 595ms
Code Editor Page Tests [CodeEditor] opens reset dialog 634ms
Code Editor Page Tests [CodeEditor] fetches libraries 18.7s

Github Test Reporter by CTRF 💚

@Thiemann96
Copy link
Contributor

Der Base branch für das Prettier update war bei dir nicht development deswegen sind zum Beispiel Änderungen im Compile Prozess noch in dieser PR. Bitte auf development wechseln. pullen und danach nen neuen "chore/prettier" branch erstellen.

@georgi-s georgi-s changed the base branch from development to feat/add-confirmation-of-successful-buffering-in-backpack-#322 May 15, 2025 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants