Skip to content

Feat/backpack wiggle animation #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: chore/prettier-check
Choose a base branch
from

Conversation

georgi-s
Copy link
Contributor

feat: Enhanced BlocklyWindow component with Backpack animation

  • Added: CSS import for Blockly animations
  • Implemented: Backpack animation with wiggle effect
  • Improved: Code quality and readability
  • Optimized: Props handling with nullish coalescing
  • Cleaned up: Removed redundant comments
  • Modernized: ES6+ syntax and best practices

- Added: CSS import for Blockly animations
- Implemented: Backpack animation with wiggle effect
- Improved: Code quality and readability
- Optimized: Props handling with nullish coalescing
- Cleaned up: Removed redundant comments
- Modernized: ES6+ syntax and best practices
Copy link

Tests

Test Name Status Flaky Duration
Blockly Editor Page Tests [Blockly] visits the editor page 1.0s
Blockly Editor Page Tests [Blockly] visits the tutorial page 189ms
Blockly Editor Page Tests [Blockly] visits the gallery page 133ms
Blockly Editor Page Tests [Blockly] visits the faq page 125ms
Blockly Editor Page Tests [Blockly] visits the settings page 128ms
Blockly Editor Page Tests [Blockly] visits the login page 133ms
Blockly Editor Page Tests [Blockly] navigates to tutorial and back 13.7s
Blockly Editor Page Tests [Blockly] selects senseBox ESP 665ms
Blockly Editor Page Tests [Blockly] selects senseBox MCU 721ms
Blockly Editor Page Tests [Blockly] selects senseBox Mini 598ms
Blockly Editor Page Tests [Blockly] compiles code 31.0s
Code Editor Page Tests [CodeEditor] visits the code editor page 1.3s
Code Editor Page Tests [CodeEditor] selects senseBox ESP 473ms
Code Editor Page Tests [CodeEditor] compiles code 619ms
Code Editor Page Tests [CodeEditor] opens reset dialog 633ms
Code Editor Page Tests [CodeEditor] fetches libraries 2.7s

Github Test Reporter by CTRF 💚

- Change transform-origin from center center to 20px 30px
- Set transformation point to 20px from left and 30px from top
- Improve animation with more precise rotation axis
Copy link

Tests

Test Name Status Flaky Duration
Blockly Editor Page Tests [Blockly] visits the editor page 947ms
Blockly Editor Page Tests [Blockly] visits the tutorial page 164ms
Blockly Editor Page Tests [Blockly] visits the gallery page 133ms
Blockly Editor Page Tests [Blockly] visits the faq page 126ms
Blockly Editor Page Tests [Blockly] visits the settings page 131ms
Blockly Editor Page Tests [Blockly] visits the login page 125ms
Blockly Editor Page Tests [Blockly] navigates to tutorial and back 14.0s
Blockly Editor Page Tests [Blockly] selects senseBox ESP 2.0s
Blockly Editor Page Tests [Blockly] selects senseBox MCU 3.2s
Blockly Editor Page Tests [Blockly] selects senseBox Mini 3.0s
Blockly Editor Page Tests [Blockly] compiles code 33.6s
Code Editor Page Tests [CodeEditor] visits the code editor page 1.3s
Code Editor Page Tests [CodeEditor] selects senseBox ESP 467ms
Code Editor Page Tests [CodeEditor] compiles code 608ms
Code Editor Page Tests [CodeEditor] opens reset dialog 606ms
Code Editor Page Tests [CodeEditor] fetches libraries 2.9s

Github Test Reporter by CTRF 💚

@Thiemann96
Copy link
Contributor

sieht gut aus, leider haben es änderungen aus anderen pr's hier rein geschafft

const link = document.createElement("a");
link.href = downloadUrl;
link.download = `${filename}.bin`;
link.download = `${timestamp}_${cleanName}.bin`;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sind zum beispiel änderungen aus einem ganz anderen pull request die es hier rein geschafft haben was eig nicht sein sollte ...

du hast als du diesen branch erstellt hast, als basis branch nicht development genommen (immer dran denken wenn du n neues feature machen willst zuerst auf development zu wechseln, zu pullen und dann von dort einen neuen branch für dein neues feature erstellen)

@georgi-s georgi-s changed the base branch from development to chore/prettier-check May 15, 2025 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants