Fix/reserved word as variable brakes the application #465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simulator fluoro bee
…nders - Added new top-view camera angle renders for sensors: * BME680 (sensorBME680 v9.png) * HDC1080 (senseBox-HDC1080_v22 v4.png) * SMT50 (SMT50 v2.png) * Water Temperature Sensor (Wassertemperatur Sensor v2.png) * SCD30 (SCD30 v1.png) * HCSR04 (hc-sr04.png) - Standardized rendering specifications: * All PNG files must be rendered in 1920x1080 (16:9 aspect ratio) * This ensures consistent appearance across all sensor graphics * Future renders must follow these dimensions for uniformity - Unified sensor display sizes in simulator: * Set maxWidth='64%' for all sensor components * Applied to ensure consistent scaling across all sensors * This setting maintains proper proportions in the simulator view Note for future developers: When adding new sensor graphics, please ensure: 1. Renders are created in 1920x1080 (16:9) resolution 2. Top-view camera angle is used for consistency 3. Set maxWidth='64%' in the sensor's React component 4. Test scaling behavior in simulator before committing
|
@felixerdy @georgi-s i think this PR superseeds this one with a simpler solution: #467 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit improves the variable validation process in the Blockly Arduino generator:
Added a new validateVariable function that performs comprehensive validation:
Implemented a flag system to prevent multiple alerts from appearing simultaneously:
Updated variable handling in setVariableFunction and getVariableFunction:
These changes ensure a better user experience by providing clear, non-repetitive feedback when invalid variable names are used.