Cleanup Code for compilation dialog #470
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Thiemann96 @georgi-s I've cleaned up the Compiler Dialog Code to follow the existing structure and using the blockly i18n language keys |
Tests
Github Test Reporter by CTRF 💚 |
Tests
Github Test Reporter by CTRF 💚 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several enhancements and refactorings across multiple files, focusing on improving maintainability, localization, and consistency in the codebase. The key changes include the addition of new theme colors, localization updates, the removal of Redux dependencies for language settings, and the renaming of files for consistency. Below is a categorized summary of the most important changes:
Theme and Styling Updates:
senseboxColors(blue and green) to the theme configuration insrc/App.jsxfor consistent color usage across components.CodeCompilationIcon,DownloadAnimation, andDragDropIconto usetheme.palette.senseboxColorsinstead of hardcodedsenseboxColors. [1] [2] [3]Localization Enhancements:
ui.js) and English (ui.js) to support compile animations and drag-and-drop features. [1] [2]DownloadAnimationandDragDropIconwith localized strings fromBlockly.Msg. [1] [2]Code Simplification and Refactoring:
DownloadAnimationandDragDropIcon, simplifying the components. [1] [2]CompilationDialog, making it a standalone component. [1] [2]File Renaming for Consistency:
code-compilation-icon.jsxtoCodeCompilationIcon.jsxandcompilation-dialog.jsxtoCompilationDialog.jsxto align with PascalCase naming conventions. [1] [2]Miscellaneous:
src/App.jsx.