Add editorconfig+SourceLink+NRT;convert to file-scoped namespaces #61
Conversation
sungam3r
changed the title
Directory.Build.props
Outdated
| <PackageRequireLicenseAcceptance>false</PackageRequireLicenseAcceptance> | ||
| <PackageIcon>serilog-extension-nuget.png</PackageIcon> | ||
| <RepositoryType>git</RepositoryType> | ||
| <DebugType>embedded</DebugType> |
There was a problem hiding this comment.
This will increase DLL size, which will negatively affect downstream consumers who ship apps with PDBs removed for size reasons.
There was a problem hiding this comment.
I know about size reasoning and saw discussions and arguments of the two dev groups on this topic. Many have come to the fact that the simple debugging out of the box wihout need to jumping over symbol servers looks much more attractive for consumers then savings on a few kilobytes of theirs apps which occupies dozens or even hundreds of megabytes.
The size of the package increases from 61KB (pdb - none) to 99KB (pdb - embedded).
There was a problem hiding this comment.
Or in terms of output dll: 18 KB vs 10KB for net core and 14KB vs 10KB for .NET targets. Does 4-8 KB make sense in 2024?
There was a problem hiding this comment.
Not all consuming scenarios are equivalent; Blazor and mobile apps often have tighter size requirements. If we did this in all Serilog projects, the additional 80% would feel like waste to me.
There was a problem hiding this comment.
So? Publish symbol package as well?
There was a problem hiding this comment.
I don't love SNUPKGs either but it seems like that's the option we're left with :-) 👍
test/Serilog.Formatting.Compact.Tests/CompactJsonFormatterTests.cs
Outdated
Show resolved
Hide resolved
Please see with
Hide whitespacesoption enabled.