Optimize IDNA tables #677
Merged
Optimize IDNA tables #677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(The linting failures are due to clippy warnings that are fixed as part of #676.) |
valenting
added a commit
that referenced
this pull request
Feb 17, 2021
Implement support for reporting errors on invalid IDNA2008 characters Includes changes from Optimize IDNA tables #677
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performance changes over 3 runs of the benchmarks:
to_ascii_merged: -5.2% (new: ~1922ns)
to_ascii_puny_label: -3.7% (new: ~1122ns)
to_ascii_simple: +2.0% (new: ~260ns, I think this is not as bad as it looks due to an outlier)
to_unicode_ascii: -1.2% (new: ~79ns)
to_unicode_merged_label: -8.8% (new: ~1858ns, I think this is not as good as it looks due to an outlier)
to_unicode_puny_label: -1.4% (new: ~1133ns)
It also appears to shave ~2.3% off the binary size for the rlib and rmeta files.