Skip to content

Increase Origin test coverage #702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 26, 2021
Merged

Conversation

BramBonne
Copy link
Contributor

@BramBonne BramBonne commented Apr 26, 2021

Add unit tests for unicode_serialization() and is_tuple().

New test coverage:
|| ../idna/src/lib.rs: 4/6 +33.33333333333333%
|| ../idna/src/uts46.rs: 158/299 +2.341137123745818%
|| src/origin.rs: 32/37 +40.54054054054054%
|| src/parser.rs: 681/848 +0.1179245283018826%

I'm planning on increasing test coverage across some other files in a similar manner if this pull request is approved.

Add unit tests for unicode_serialization() and is_tuple().

New test coverage:
|| ../idna/src/lib.rs: 4/6 +33.33333333333333%
|| ../idna/src/uts46.rs: 158/299 +2.341137123745818%
|| src/origin.rs: 32/37 +40.54054054054054%
|| src/parser.rs: 681/848 +0.1179245283018826%
@valenting valenting merged commit 12310f2 into servo:master Apr 26, 2021
@BramBonne BramBonne deleted the origin_tests branch April 26, 2021 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants