SHOT-4439: Add new file handling for Nx File (.prt) #183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds new file handling support for Nx File (.prt) by introducing a corresponding configuration entry in the tk-multi-loader2 settings YAML.
- Added configuration for Nx File (.prt) with associated import options.
- Updated the settings file to support the new file type.
staceyoue
force-pushed
the
ticket/SHOT-4439-nx-file
branch
from
d31e147 to
68732b3
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for handling new Nx File (.prt) types in the tk-multi-loader2 settings.
- Added an entry for Nx File (.prt) to the allowed file types.
Comments suppressed due to low confidence (1)
env/includes/settings/tk-multi-loader2.yml:397
- [nitpick] Consider revising the naming of the file type to improve consistency. For example, if other file types are named without additional punctuation, you may want to adjust to something like 'Nx File .prt' or remove the parentheses if they are not required.
Nx File(.prt): [import, import_with_options]
staceyoue
force-pushed
the
ticket/SHOT-4439-nx-file
branch
from
68732b3 to
c3f6ed2
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for handling Nx File (.prt) by updating the loader settings configuration.
- Introduces a new configuration line for "Nx File" with options [import, import_with_options].
Comments suppressed due to low confidence (1)
env/includes/settings/tk-multi-loader2.yml:397
- Consider adding tests for the new Nx File handling to confirm that it is properly integrated and functions as expected.
Nx File: [import, import_with_options]
carlos-villavicencio-adsk
approved these changes
May 20, 2025
julien-lang
approved these changes
May 20, 2025
eduardoChaucaGallegos
approved these changes
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.