Skip to content

SHOT-4439: Update VRED actions for loader and panel #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2025

Conversation

staceyoue
Copy link
Contributor

  • Split 'import_sceneplate' action into two actions for importing front and back sceneplates
  • Add 'Nx File' to panel app

* Split 'import_sceneplate' action into two actions for importing
  front and back sceneplates
* Add 'Nx File' to panel app
@staceyoue staceyoue requested a review from Copilot May 23, 2025 13:05
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

The PR updates the VRED actions in both the Shotgun panel and the loader to split the generic import_sceneplate into distinct import_front_sceneplate and import_back_sceneplate actions, and adds support for “Nx File” imports.

  • Split import_sceneplate into front/back actions for Image and Rendered Image types
  • Added “Nx File” import action to the Shotgun panel configuration

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
env/includes/settings/tk-multi-shotgunpanel.yml Added Nx File import filter and replaced sceneplate actions
env/includes/settings/tk-multi-loader2.yml Replaced loader sceneplate actions with front/back actions
Comments suppressed due to low confidence (4)

env/includes/settings/tk-multi-shotgunpanel.yml:325

  • The indentation for the new - actions: [import] entry is inconsistent with surrounding entries; it should match the existing 6-space indent to ensure valid YAML.
    - actions: [import]

env/includes/settings/tk-multi-shotgunpanel.yml:335

  • This actions line is indented differently than the filters line below; align it to the same indent level as its peer entries for proper parsing.
    - actions: [import_front_sceneplate, import_back_sceneplate]

env/includes/settings/tk-multi-loader2.yml:400

  • Indentation for the Image key should match surrounding file-type mappings (e.g., 6 spaces) to maintain valid YAML structure.
    Image: [import_front_sceneplate, import_back_sceneplate]

env/includes/settings/tk-multi-loader2.yml:401

  • The Rendered Image mapping is misaligned compared to its peers; please adjust the indent to match other file-type entries.
    Rendered Image: [import_front_sceneplate, import_back_sceneplate]

@staceyoue staceyoue requested a review from a team May 23, 2025 13:33
@staceyoue staceyoue merged commit c5ef07f into master May 26, 2025
12 checks passed
@staceyoue staceyoue deleted the ticket/SHOT-4439-vred-actions branch May 26, 2025 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants