Skip to content

fix: remove machine set allocation source option #1161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Unix4ever
Copy link
Member

This option is redundant. It was inteded for MCP, but the MCP implementation will not be using it, so we should stop dragging it along anymore.

This change was extracted from #723

This option is redundant. It was inteded for MCP, but the MCP
implementation will not be using it, so we should stop dragging it along
anymore.

This change was extracted from siderolabs#723

Signed-off-by: Artem Chernyshev <[email protected]>
Copy link
Member

@Orzelius Orzelius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I like the simplification, especially in the state validation and machine set node controller logic.

@Unix4ever
Copy link
Member Author

/m

@talos-bot talos-bot merged commit ff03233 into siderolabs:main Apr 30, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants