Skip to content

break screen shortcuts: implement on wayland #716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

deltragon
Copy link
Collaborator

Description

Fixes #480.

I've also fixed a bug where on X11, the shortcuts were not disabled in some situations (eg. by the limitconsecutiveskipping plugin). See the second commit.

deltragon added 3 commits May 9, 2025 19:54
previously, it was possible to bypass the limitconsecutiveskipping
plugin by pressing space or escape.
@deltragon deltragon self-assigned this May 9, 2025
@deltragon
Copy link
Collaborator Author

How to test this:
Start a break. Wait 2 seconds after the break screen appears. (This delay is configurable by the "Keyboard shortcuts disabled period" setting, and defaults to 2s.)
When skipping is enabled, press the "Escape" key to skip the break. When disabled, "Escape" should do nothing.
When postponing is enabled, press the "Space" key to postpone the break. When disabled, "Skip" should do nothing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Escape key doesn't work on wayland
1 participant