Bugfix/issue 1745 simplify locking #1747
Draft
+1,420
−374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* switch to barrier_async calls
* Updating locking on mutable dictionary to not crash if called from its own queue
joeljfischer
added
the
best practice
Codecov Report
@@ Coverage Diff @@
## develop #1747 +/- ##
===========================================
+ Coverage 84.01% 84.07% +0.06%
===========================================
Files 408 410 +2
Lines 20899 21010 +111
===========================================
+ Hits 17558 17664 +106
- Misses 3341 3346 +5 |
# Conflicts: # SmartDeviceLink-iOS.xcodeproj/project.pbxproj
* Add locked map table * Integrate to SystemCapabilityManager * Start integration on response dispatcher
* Creating mutable set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1745
Risk
This PR makes no API changes.
Testing Plan
Unit Tests
Unit tests were added for the new classes.
Core Tests
[List of tests performed against Core and behaviors verified]
Core version / branch / commit hash / module tested against: [INSERT]
HMI name / version / branch / commit hash / module tested against: [INSERT]
Summary
This PR adds a new mutable dictionary class and mutable array class that provide thread-safety around accesses by using a queue passed to the class. This is intended to simplify locks around dictionaries and arrays in the SDL project by unifying them into one testable class.
Changelog
Other
Tasks Remaining:
CLA