Finished API implementation and Base for CLI-Tool #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update deprecated call datetime.utcnow() with datetime.now(UTC) fix test where data was provides as list and not as str.
better error message for SxapiAuthorizationError raise custom errors instead of return an integer != 0 fix failing test from resulting raises
|
@flowolf updated the changed we talked about
|
flowolf
requested changes
Feb 25, 2025
src/sxapi/cli/cli.py
Outdated
| def run(self): | ||
| """Call sxapi functions based on passed arguments.""" | ||
| args = self.parse_args(sys.argv[1:]) | ||
| if not args: | ||
| return 0 | ||
| return |
There was a problem hiding this comment.
should this throw an exception?
There was a problem hiding this comment.
mhm i assume the Outdated Label means you have reviewed an older commit.
I also cant find this code snipped at this file anymore 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR should be seen as a good base for further development. All Implemented features a working and are fully test (90% test coverage).
This PR introduces a complete redesign of the CLI and a complete implementation of the public API's. (more information below).
For the foreseeable future I will stop working on this project, because of:
API
This PR contains the complete implementation of every public API Endpoint provided via
PublicAPIv2andIntegrationAPIV2. Located insxapi/src/<publicV2|integrationV2>CLI
It also contains a basis for further CLI Tool implementations. Can be found under
sxapi/src/cli.There already some example Implementations for the CLI -> the animals, abort and token parser.
I did did full rebuild of the CLI design, thats why the approach is completely different from previous one.
The CLI now follows a
kubectlstyle design, likesxapi animals get --ids <id1> <id2>sxapi aborts delete <animal_id> <abort_id>