Skip to content

General CSS & JS Update #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

General CSS & JS Update #28

wants to merge 3 commits into from

Conversation

Dade88
Copy link

@Dade88 Dade88 commented Oct 20, 2018

Bootstrap 4.1.3
Font Awesome 4.7.0
AutoComplete 1.4.9

Bootstrap 4.1.3
Font Awesome 4.7.0
AutoComplete 1.4.9
@Dade88 Dade88 mentioned this pull request Oct 20, 2018
Automatically disable Joomla Bootstrap JavaScript without "JUI Disable" plugin.

Added the following options under "Advanced" tabs:
- Load Template Local Files (default YES), allowing admins to use local or CDN files. This also disables Joomla Core JQuery in order to prevent conflicts.
- Joomla Meta Generator (default DISABLED)

New tab "Disable J! Files", includes the following checkboxes:
- J! Core files. If checked, disables all Joomla cora assets
- J! Bootstrap JS File. If checked, disables only Joomla Bootstrap JavaScript
- J! Caption. If checked, disables only Joomla Caption JavaScript
- J! Core JQuery File. If checked, disables only Joomla JQuery JavaScript
- J! Core JQuery Migrate File. If checked, disables only Joomla JQuery Migrate JavaScript
- J! Core NoConflict File. If checked, disables only Joomla JQuery NoConflict JavaScript

I also created helper.php in order to keep index.php cleaner with the new options.
@Dade88
Copy link
Author

Dade88 commented Oct 20, 2018

Template administration and optimization

Automatically disable Joomla Bootstrap JavaScript without "JUI Disable" plugin.

Added the following options under "Advanced" tabs:

  • Load Template Local Files (default YES), allowing admins to use local or CDN files. This also disables Joomla Core JQuery in order to prevent conflicts.
  • Joomla Meta Generator (default DISABLED)

New tab "Disable J! Files", includes the following checkboxes:

  • J! Core files. If checked, disables all Joomla cora assets
  • J! Bootstrap JS File. If checked, disables only Joomla Bootstrap JavaScript
  • J! Caption. If checked, disables only Joomla Caption JavaScript
  • J! Core JQuery File. If checked, disables only Joomla JQuery JavaScript
  • J! Core JQuery Migrate File. If checked, disables only Joomla JQuery Migrate JavaScript
  • J! Core NoConflict File. If checked, disables only Joomla JQuery NoConflict JavaScript

I also created helper.php in order to keep index.php cleaner with the new options.

jwiesel added a commit that referenced this pull request Oct 25, 2018
@jwiesel
Copy link
Contributor

jwiesel commented Oct 25, 2018

Hi @Dade88 ,
thanks for your pull-request.
In the meantime I updated to Bootstrap 4.1.3, too. The "Autocomplete" update made me think. In the end I removed it completely to just use it from JUI.
I'll have a look at the template admin changes after version 1.11 together with the changes proposed in #26.

@Dade88
Copy link
Author

Dade88 commented Oct 25, 2018

You welcome, nice to see you @jwiesel :)

I'd like to make more changes to the back-end in the future (for example, ability to pick FontAwesome 4 -default - or FA5), but I tried to make the more urgents - at least to me - changes on this one.

Small improvements with HTML5 and SEO.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants