Provide option to limit number of cached entries per key #121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjwallace
force-pushed
the
storage_max_entries
branch
from
978572e to
6d2f119
Compare
tjwallace
changed the title
tjwallace
commented
Oct 2, 2020
| @@ -83,6 +83,7 @@ class HttpCache < Faraday::Middleware | |||
| # :instrumenter - An instrumentation object that should respond to 'instrument'. | |||
| # :instrument_name - The String name of the instrument being reported on (optional). | |||
| # :logger - A logger object. | |||
| # :max_entries - The maximum number of entries to store per cache key. | |||
There was a problem hiding this comment.
Maybe a better name would be max_entries_per_(cache_)key?
|
@tjwallace I'm sorry for the late reply on this PR. I'm assuming as a maintainer. If you still interested on this solution: You can rebase this PR and solve the conflicts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #112