fix: ensure aggregate checks run on original input DataFrame #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📍 Context
Previously, aggregate checks like schema-check failed unexpectedly due to internal columns (_dq_errors, _dq_passed) being added by row-level validations before schema validation was performed.
🛠 What’s fixed
This MR ensures that all aggregate checks are executed on the original, unmodified input DataFrame. This prevents false failures caused by internal metadata columns.
🧪 Test coverage
Includes an end-to-end test verifying that a valid schema passes when combined with other checks like NullCheck.
🙏 Thanks
Thanks to @tongqqiu for reporting this! Your feedback helped fix this issue quickly.