Skip to content

IBM DB2 support #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jul 7, 2017
Merged

IBM DB2 support #25

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
d71f64a
Make line comments configurable
Jun 16, 2017
dc8f3b2
Setup DB2 reserved words and formatter
Jun 17, 2017
2de4607
Add missing semicolon
Jun 17, 2017
a37bfc6
Make col#1 and col@miami words
Jun 17, 2017
92fd10e
Update README and demo
Jun 17, 2017
a727543
I wonder why Atom is removing this semicolon
Jun 17, 2017
15eb73f
Write a separate test with clear description, explaining the @ and # …
Jul 4, 2017
c4c1da2
Use @ and # chars as identifiers only in DB2 dialect formatter
Jul 4, 2017
1d3d93e
Remove useless test cfg
Jul 4, 2017
b9b58bb
Try to make newline and toplevel words list easier to compare
Jul 4, 2017
d64838d
Improve DB2 test description
Jul 6, 2017
a0d16a4
Remove | from word regex
Jul 6, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Write a separate test with clear description, explaining the @ and # … 
…are part of identifiers
  • Loading branch information
Uku Pattak committed Jul 4, 2017
commit 15eb73faaed91c0acc91fa219bc7f717d4165a3c
17 changes: 15 additions & 2 deletions test/Db2FormatterTest.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,20 +22,33 @@ describe("Db2Formatter", function() {

it("formats only -- as a line comment", function() {
const result = sqlFormatter.format(
"SELECT col#1 FROM\n" +
"SELECT col FROM\n" +
"-- This is a comment\n" +
"MyTable;\n",
{language: "db2"}
);
expect(result).toBe(
"SELECT\n" +
" col#1\n" +
" col\n" +
"FROM\n" +
" -- This is a comment\n" +
" MyTable;\n"
);
});
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also test the formatting of @ and # inside identifiers. This test partially covers the latter, but it would be better to have a separate test with clear description, explaining the @ and # are part of identifiers (e.g. not treated as operators).


it("recognizes @ and # as identifiers", function() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be more correct to say: "as part of identifiers"

const result = sqlFormatter.format(
"SELECT col#1, @col2 FROM tbl\n"
);
expect(result).toBe(
"SELECT\n" +
" col#1,\n" +
" @col2\n" +
"FROM\n" +
" tbl\n"
);
});

it("recognizes :variables", function() {
expect(sqlFormatter.format("SELECT :variable;", {language: "db2"})).toBe(
"SELECT\n" +
Expand Down