Skip to content

Exclusive Cache Lock #8209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 44 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
8674a8b
Cache Lock
yschimke Jan 20, 2024
c3df60f
Merge branch 'master' into cache_singleton
yschimke Apr 1, 2024
166a255
Merge branch 'master' into cache_singleton
yschimke Apr 1, 2024
b02738d
Rework
yschimke Apr 1, 2024
ac0cc79
Rework
yschimke Apr 1, 2024
2525edf
Add test
yschimke Apr 1, 2024
7072358
Cleanup
yschimke Apr 1, 2024
5ca131f
Activate missed test
yschimke Apr 1, 2024
0a2fbb6
Cleanup
yschimke Apr 1, 2024
c9db9d4
Avoid checking on non system file systems
yschimke Apr 1, 2024
97e566b
Revert "Avoid checking on non system file systems"
yschimke Apr 1, 2024
ee1daa6
Avoid failing on dns tests
yschimke Apr 1, 2024
3041258
Adding a test
yschimke Apr 2, 2024
7faba3e
Fixes
yschimke Apr 2, 2024
44d3640
Test on more platforms
yschimke Apr 3, 2024
792b689
Cleanup
yschimke Apr 3, 2024
5117f46
Merge branch 'master' into cache_singleton
yschimke Apr 3, 2024
a922b1d
Cleanup
yschimke Apr 3, 2024
e24e146
Fixes
yschimke Apr 6, 2024
04c057f
Fixes
yschimke Apr 6, 2024
5c6c60d
Cache fixes
yschimke Apr 6, 2024
12b7eb9
Cache fixes
yschimke Apr 6, 2024
ae3830d
Cache fixes
yschimke Apr 6, 2024
99a5ee5
Cache fixes
yschimke Apr 6, 2024
cc97769
Cache fixes
yschimke Apr 6, 2024
6dbb03f
Fix test
yschimke Apr 6, 2024
19be22b
Merge branch 'refs/heads/master' into cache_singleton
yschimke Apr 6, 2024
feafff9
Fix test
yschimke Apr 6, 2024
72359a6
avoid windows for now
yschimke Apr 6, 2024
b76aa7f
Fix or skip on windows
yschimke Apr 7, 2024
89e9d80
cleanup
yschimke Apr 7, 2024
28025e2
skip on windows
yschimke Apr 7, 2024
fa707bc
Update DuplexTest.kt
yschimke Apr 7, 2024
c5a87f0
Merge branch 'master' into cache_singleton
yschimke Jan 4, 2025
bb0d4b0
Fixes
yschimke Jan 4, 2025
192e93b
Fixes
yschimke Jan 4, 2025
b4115b2
Fixes
yschimke Jan 4, 2025
2f959af
Fixes
yschimke Jan 4, 2025
7af5705
Fixes
yschimke Jan 4, 2025
4e9d4b3
Fix test
yschimke Jan 11, 2025
019560c
reformat
yschimke Jan 11, 2025
433f6f7
Make it optional
yschimke Jan 11, 2025
b650c9a
Merge branch 'master' into cache_singleton
yschimke May 10, 2025
f9479e8
reformat
yschimke May 10, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Rework
  • Loading branch information
yschimke committed Apr 1, 2024
commit b02738d07d657e54918707ce274d6d9e5e43c76d
24 changes: 22 additions & 2 deletions okhttp/src/main/kotlin/okhttp3/internal/cache/CacheLock.kt
Original file line number Diff line number Diff line change
@@ -1,3 +1,18 @@
/*
* Copyright (C) 2023 Block, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package okhttp3.internal.cache

import android.annotation.SuppressLint
Expand All @@ -7,14 +22,15 @@ import java.nio.file.StandardOpenOption
import java.util.Collections
import okhttp3.internal.platform.Platform
import okio.FileSystem
import okio.IOException
import okio.Path

internal object CacheLock {
private val openCaches = Collections.synchronizedMap(mutableMapOf<Path, Exception>())

fun openLock(fileSystem: FileSystem, directory: Path): Closeable {
return if (fileSystem == FileSystem.SYSTEM && !Platform.isAndroid) {
fileSystemLock(directory)
fileSystemLock(inMemoryLock(directory), directory)
} else {
inMemoryLock(directory)
}
Expand All @@ -33,11 +49,15 @@ internal object CacheLock {
}

@SuppressLint("NewApi")
fun fileSystemLock(directory: Path): Closeable {
fun fileSystemLock(memoryLock: Closeable, directory: Path): Closeable {
val lockFile = directory / "lock"
lockFile.toFile().createNewFile()
val channel = FileChannel.open(lockFile.toNioPath(), StandardOpenOption.APPEND)

channel.tryLock() ?: throw IOException("Cache $directory is locked by another process")

return okio.Closeable {
memoryLock.close()
channel.close()
}
}
Expand Down