-
Notifications
You must be signed in to change notification settings - Fork 23
Caracal Ubuntu Noble support #1595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alex-Welsh
reviewed
Apr 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good so far
I've had a quick look and added a few comments, let me know when it's ready for a full review
8e0e7a0
to
9fd00c9
Compare
da6e3ba
to
7841f3a
Compare
347e17b
to
3306375
Compare
3306375
to
10eb8db
Compare
9a62bde
to
5cd694c
Compare
558232b
to
e90f5f9
Compare
Alex-Welsh
reviewed
Apr 16, 2025
releasenotes/notes/add-ubuntu-noble-support-caracal-1b9e64d4aa2e1ff7.yaml
Outdated
Show resolved
Hide resolved
e90f5f9
to
2d78cb2
Compare
Default version of docker running on Ubuntu Noble is 28.0.4. This version is now tested. As SCT is using this value as exlusive max, bumping to 28.1.0 to ensure 28.0.4 is included.
Co-authored-by: Alex-Welsh <[email protected]>
Co-authored-by: Alex-Welsh <[email protected]>
2d78cb2
to
624cb88
Compare
Alex-Welsh
approved these changes
Apr 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.