Remove .git for glance_store override to fix pip dependency conflict #1596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alex-Welsh
approved these changes
Apr 4, 2025
priteau
approved these changes
Apr 4, 2025
There was a problem hiding this comment.
I didn't realise @technowhizz's change would have this effect.
|
@priteau Two CIs didn't pass due to have unrelated SCT failures. Can we consider just merging this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we override glance_store with our fork
glance_store[cinder,vmware,swift,s3]@git+https://github.com/stackhpc/glance_store.git@stackhpc/4.7.0.3But upper-constraints and glance expects
glance_store[cinder,vmware,swift,s3]@git+https://github.com/stackhpc/glance_store@stackhpc/4.7.0.3This confuses pip and it handles this as a dependency conflict resulting glance image build failure.
Fixing by removing
.gitat the end of source url