Skip to content

Add unit (GiB) to LowMemory alert #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 14, 2023
Merged

Add unit (GiB) to LowMemory alert #437

merged 2 commits into from
Mar 14, 2023

Conversation

technowhizz
Copy link
Contributor

Adds the word GB to the low memory alert to make more sense of the alert

@technowhizz technowhizz requested a review from a team as a code owner March 9, 2023 12:24
@technowhizz technowhizz self-assigned this Mar 9, 2023
priteau
priteau requested changes Mar 9, 2023
View reviewed changes
Copy link
Member

@priteau priteau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could say GiB to be more precise.

@technowhizz technowhizz changed the title Add unit (GB) to LowMemory alert Add unit (GiB) to LowMemory alert Mar 9, 2023
@technowhizz technowhizz force-pushed the fix/alert-units branch 2 times, most recently from d1941aa to 3a5a61f Compare March 9, 2023 12:32
@technowhizz
Copy link
Contributor Author

You could say GiB to be more precise.

Done

priteau
priteau requested changes Mar 9, 2023
View reviewed changes
priteau
priteau requested changes Mar 9, 2023
View reviewed changes
Copy link
Member

@priteau priteau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now you are missing a newline at the end…

@technowhizz technowhizz force-pushed the fix/alert-units branch 2 times, most recently from e364571 to 525bdcb Compare March 9, 2023 15:29
@technowhizz technowhizz enabled auto-merge (squash) March 9, 2023 15:52
@technowhizz technowhizz requested a review from priteau March 9, 2023 17:05
priteau
priteau requested changes Mar 9, 2023
View reviewed changes
priteau
priteau approved these changes Mar 10, 2023
View reviewed changes
Copy link
Member

@priteau priteau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating.

@technowhizz technowhizz merged commit 7748d7b into stackhpc/xena Mar 14, 2023
@technowhizz technowhizz deleted the fix/alert-units branch March 14, 2023 10:35
@markgoddard markgoddard mentioned this pull request Mar 15, 2023
Merged
@markgoddard markgoddard mentioned this pull request Sep 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@priteau priteau priteau approved these changes

Assignees

@technowhizz technowhizz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@technowhizz @priteau