Skip to content

rocky: disable elasticsearch-curator by default #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

mnasiadka
Copy link
Member

No description provided.

@mnasiadka mnasiadka requested a review from a team as a code owner April 17, 2023 07:37
@@ -577,7 +577,7 @@ kolla_enable_central_logging: true
#kolla_enable_designate:
#kolla_enable_destroy_images:
#kolla_enable_elasticsearch:
kolla_enable_elasticsearch_curator: true
kolla_enable_elasticsearch_curator: "{{ not os_distribution == 'rocky' }}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surely this should be handled by kayobe/kolla-ansible?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More like Kayobe, but we're explicitly enabling that - so what Kayobe/Kolla-Ansible should do - fail on prechecks?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about kolla_enable_elasticsearch_curator: "{{ kolla_enable_elasticsearch }}"? Is this acceptable?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, if enable_elasticsearch is false on rocky, then does it matter whether curator is enabled?

Copy link
Member Author

@mnasiadka mnasiadka Apr 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no container image for elasticsearch-curator - so it won't pull. But let me check.
Actually - @grzegorzkoper reported that, but now I think it's not needed - because he had kayobe code without the opensearch patch. Shouldn't be needed anymore.

@mnasiadka mnasiadka closed this Apr 17, 2023
@mnasiadka mnasiadka deleted the yoga_rl9_curator branch November 16, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants