Update/smartmon playbook #542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jovial
reviewed
Jun 23, 2023
technowhizz
force-pushed
the
update/smartmon-playbook
branch
from
3a87651 to
df0c7d3
Compare
Adds a check to ensure that cron is installed before attempting to configure the crontab.
technowhizz
force-pushed
the
update/smartmon-playbook
branch
from
df0c7d3 to
111d163
Compare
Alex-Welsh
reviewed
Jun 23, 2023
jovial
reviewed
Jun 23, 2023
| package: | ||
| name: | ||
| - smartmontools | ||
| - nvme-cli | ||
| - jq | ||
| - "{{ 'cron' if ansible_facts['distribution'] == 'Ubuntu' else 'cronie' }}" |
There was a problem hiding this comment.
nit: using ansible_facts['os_family'] == 'Debian' might be more generic, but given that that we only support Ubuntu/Redhat this looks OK.
jovial
approved these changes
Jun 23, 2023
markgoddard
reviewed
Jun 26, 2023
| @@ -2,12 +2,13 @@ | |||
| - hosts: overcloud | |||
|
|
|||
| tasks: | |||
| - name: Ensure smartmon-tools and nvme-cli is installed | |||
| - name: Ensure smartmon-tools, jq, nvme-cli and cron/cronie is installed | |||
There was a problem hiding this comment.
This is why I usually just put "packages" or "package dependencies" :)
There was a problem hiding this comment.
Ah. Will bear in mind for next time
markgoddard
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that cron is installed before attempting to configure crontab