Skip to content

Apply centos build customisations on rocky also #719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 20, 2023
Merged

Apply centos build customisations on rocky also #719

merged 1 commit into from
Oct 20, 2023

Conversation

mnasiadka
Copy link
Member

No description provided.

@mnasiadka mnasiadka marked this pull request as ready for review October 20, 2023 13:31
@mnasiadka mnasiadka requested a review from a team as a code owner October 20, 2023 13:31
@priteau
Copy link
Member

priteau commented Oct 20, 2023

What about also renaming the variable to kolla_build_customizations_redhat?

@Alex-Welsh
Copy link
Member

What about also renaming the variable to kolla_build_customizations_redhat?

kolla_build_customizations_rhel would probably match the variable naming in the rest of the file best

@mnasiadka
Copy link
Member Author

What about also renaming the variable to kolla_build_customizations_redhat?

kolla_build_customizations_rhel would probably match the variable naming in the rest of the file best

I would go for kolla_build_customizations_rpm or _el - so which one?

@priteau
Copy link
Member

priteau commented Oct 20, 2023

What about also renaming the variable to kolla_build_customizations_redhat?

kolla_build_customizations_rhel would probably match the variable naming in the rest of the file best

I would go for kolla_build_customizations_rpm or _el - so which one?

rpm would make sense if the other variable was deb instead of ubuntu. We use a mix of rhel and el, I slightly prefer the former but feel free to pick el if you prefer.

@mnasiadka mnasiadka force-pushed the yoga_rocky_customizations branch from 1142789 to 0c7e209 Compare October 20, 2023 13:48
@mnasiadka mnasiadka force-pushed the yoga_rocky_customizations branch from 0c7e209 to 2708827 Compare October 20, 2023 13:51
@mnasiadka mnasiadka merged commit 622743d into stackhpc/yoga Oct 20, 2023
@mnasiadka mnasiadka deleted the yoga_rocky_customizations branch October 20, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@priteau priteau priteau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mnasiadka @priteau @Alex-Welsh