Fix evaluation of step conditions #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Despite specifying the boolean type for inputs, GitHub workflow variables are actually strings so 'false' evaluates to true. This was causing the seed container image build to always be executed. See actions/runner#1483 for more details.
priteau
requested review from
darmach,
markgoddard,
mnasiadka,
cityofships and
bbezak
cityofships
approved these changes
Jun 3, 2022
|
:( thanks for fixing |
What are the pros & cons? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Despite specifying the boolean type for inputs, GitHub workflow
variables are actually strings so 'false' evaluates to true. This was
causing the seed container image build to always be executed.
See actions/runner#1483 for more details.