-
Notifications
You must be signed in to change notification settings - Fork 23
Add all-in-one CI testing #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a732baf
to
813b3ec
Compare
This is used for Continuous Integration/Continuous Deployment (CI/CD).
This file is necessary for kayobe-automation.
kayobe-automation prefers to have kayobe installed via requirements.txt in kayobe-config. For now we're just installing the stackhpc/wallaby branch of the StackHPC fork of kayobe.
f2e0741
to
14e7da5
Compare
It probably needs a little more work, but wanted to get your thoughts @jovial |
e9bca45
to
29bfd36
Compare
* add a workflow to build the kayobe-automation image The image is published on Google packages. https://github.com/stackhpc/stackhpc-kayobe-config/pkgs/container/stackhpc-kayobe-config * add a workflow to run an all-in-one test * call both workflows for PR events
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Is there anything in here that would conflict with existing consumer configuration? Perhaps |
I've been making things conditional on the kayobe environment:
so we could supply a basic configuration that could be used for client side CI and put any upstream specifics behind guards like this. Yes it would merge conflict, but at least that provides a nice way of keeping it up to date. What do you reckon? The one slight gotcha is that you need to supply KAYOBE_ENVIRONMENT instead of relying on Edit: reworded slightly |
I did that for the concurrency (adapted from SOS), is there anything else it needs to be done for? |
Don't have any good examples really, but I've started shipping some additional test lists:
Trying to establish a convention for where to place tempest overrides. It basically does first found on:
Trying to go for convention over configuration here, so that people don't start doing it in multiple different ways. Maybe that shouldn't be in the config file, but i started there whilst experimenting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New changes look good to me.
requirements.txt