Allow paths without resolving modifiers inside plugin code. #7740
Conversation
|
This change is |
gilbens-starkware
force-pushed
the
gil/plugin_exclude
branch
from
1992ae8 to
ecaabcf
Compare
There was a problem hiding this comment.
Reviewed 3 of 4 files at r1, all commit messages.
Reviewable status: 3 of 4 files reviewed, 1 unresolved discussion (waiting on @dean-starkware)
crates/cairo-lang-semantic/src/resolve/mod.rs line 241 at r1 (raw file):
/// Is the code in context was generated from a plugin macro. If so, suppress the requirement /// for resolving modifiers ($callsite or $defsite) in user defined macro paths. pub is_inside_plugin_macro: bool,
f2f
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware)
gilbens-starkware
force-pushed
the
gil/plugin_exclude
branch
from
ecaabcf to
4b37f4d
Compare
gilbens-starkware
force-pushed
the
gil/plugin_exclude
branch
from
4b37f4d to
bdde5b5
Compare
There was a problem hiding this comment.
Reviewable status: 1 of 6 files reviewed, 1 unresolved discussion (waiting on @dean-starkware and @orizi)
crates/cairo-lang-semantic/src/resolve/mod.rs line 241 at r1 (raw file):
Previously, orizi wrote…
f2f
Done.
There was a problem hiding this comment.
Reviewed 5 of 5 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @gilbens-starkware)
No description provided.