-
Notifications
You must be signed in to change notification settings - Fork 604
Use different cycle prevention in inlining. #7742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
18379ed
to
96216c5
Compare
This stack of pull requests is managed by Graphite. Learn more about stacking. |
96216c5
to
28975a7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 19 of 28 files at r1, 19 of 23 files at r2, 5 of 8 files at r3, 6 of 6 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ilyalesokhin-starkware)
crates/cairo-lang-lowering/src/inline/test_data/inline
line 986 at r4 (raw file):
//! > Motivation: //! #[inline] functions should inline a function unless they are on a call cycle.\ //! in this test `bar` should be inlined into `foo`.
Suggestion:
//! #[inline] functions should inline a function unless they are on a call cycle.\
//! in this test `bar` should not be inlined into `foo`.
28975a7
to
1f371bc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 29 of 30 files reviewed, all discussions resolved (waiting on @ilyalesokhin-starkware)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r5.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @ilyalesokhin-starkware)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 6 files at r4, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ilyalesokhin-starkware)
No description provided.