Skip to content

Made get_children into a query again. #7761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

orizi
Copy link
Collaborator

@orizi orizi commented May 18, 2025

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@orizi orizi force-pushed the orizi/get-children-as-query branch from 4c3884f to ecce681 Compare May 18, 2025 12:31
Copy link
Collaborator

@piotmag769 piotmag769 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It improved diagnostics calculation on OZ main from ~ 1 min 30 s to ~ 52 s

Reviewed 13 of 13 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @integraledelebesgue, @mkaput, and @TomerStarkware)

@orizi orizi force-pushed the orizi/get-children-as-query branch from ecce681 to 5899022 Compare May 19, 2025 05:02
Copy link
Collaborator Author

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 6 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @integraledelebesgue, @mkaput, and @TomerStarkware)

@orizi orizi force-pushed the orizi/get-children-as-query branch from 5899022 to b8a3076 Compare May 19, 2025 05:07
Copy link
Collaborator Author

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r3.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @integraledelebesgue, @mkaput, and @TomerStarkware)

@orizi orizi enabled auto-merge May 19, 2025 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants