Skip to content

fix: types, style #7769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: spr/main/28a22c92
Choose a base branch
from
Open

fix: types, style #7769

wants to merge 1 commit into from

Conversation

FroyaTheHen
Copy link
Collaborator

@FroyaTheHen FroyaTheHen commented May 19, 2025

  • fixes and unifies Types resolving
  • style improvements

@reviewable-StarkWare
Copy link

This change is Reviewable

@FroyaTheHen FroyaTheHen self-assigned this May 19, 2025
@FroyaTheHen FroyaTheHen marked this pull request as ready for review May 19, 2025 11:13
@FroyaTheHen FroyaTheHen requested review from orizi and mkaput as code owners May 19, 2025 11:13
Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @mkaput)


a discussion (no related file):
can you split the PR into code moving and the other stuff?
i cannot actually know what are the changes currently.

@FroyaTheHen FroyaTheHen changed the base branch from main to spr/main/2ccaefee May 21, 2025 09:00
@FroyaTheHen FroyaTheHen changed the base branch from spr/main/2ccaefee to main May 21, 2025 09:18
@FroyaTheHen FroyaTheHen changed the base branch from main to spr/main/b8085abe May 21, 2025 09:19
commit-id:6ed86016
@FroyaTheHen FroyaTheHen changed the base branch from spr/main/b8085abe to main May 21, 2025 11:14
@FroyaTheHen FroyaTheHen changed the base branch from main to spr/main/28a22c92 May 21, 2025 11:14
Copy link
Collaborator Author

@FroyaTheHen FroyaTheHen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @mkaput and @orizi)


a discussion (no related file):

Previously, orizi wrote…

can you split the PR into code moving and the other stuff?
i cannot actually know what are the changes currently.

of course, sorry about that!
see separated changes #7777

Copy link
Collaborator

@orizi orizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @FroyaTheHen and @mkaput)


a discussion (no related file):

Previously, FroyaTheHen (Kinga Cepielik) wrote…

of course, sorry about that!
see separated changes #7777

cool LGTMed - in any case - please make sure the commits clearly states what the PR does as a sentence, and not as a number of keywords.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants