-
Notifications
You must be signed in to change notification settings - Fork 604
fix: types, style #7769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: spr/main/28a22c92
Are you sure you want to change the base?
fix: types, style #7769
Conversation
FroyaTheHen
commented
May 19, 2025
•
edited
Loading
edited
- fixes and unifies Types resolving
- style improvements
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @mkaput)
a discussion (no related file):
can you split the PR into code moving and the other stuff?
i cannot actually know what are the changes currently.
e73ad4a
to
c2bb43a
Compare
c2bb43a
to
93f5606
Compare
commit-id:6ed86016
93f5606
to
5ab266a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @mkaput and @orizi)
a discussion (no related file):
Previously, orizi wrote…
can you split the PR into code moving and the other stuff?
i cannot actually know what are the changes currently.
of course, sorry about that!
see separated changes #7777
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @FroyaTheHen and @mkaput)
a discussion (no related file):
Previously, FroyaTheHen (Kinga Cepielik) wrote…
of course, sorry about that!
see separated changes #7777
cool LGTMed - in any case - please make sure the commits clearly states what the PR does as a sentence, and not as a number of keywords.