added shot circuiting to get text of terminals

[TomerStarkware]

No description provided.

[reviewable-StarkWare]

This change is 

[orizi]

Reviewed 8 of 10 files at r1, all commit messages.
Reviewable status: 8 of 10 files reviewed, 3 unresolved discussions

---

-- commits line 2 at r1:

Suggestion:

- ceb8ca7: added shortcut for getting text of terminals

---

crates/cairo-lang-syntax/src/node/helpers.rs line 155 at r1 (raw file):

        let green_node = self.as_syntax_node().green_node(db);
        let GreenNodeDetails::Node { children, .. } = &green_node.details else {
            unreachable!("Expected a node for PathSegment");

I don't understand the message.
same in the other 2.

Code quote:

            unreachable!("Expected a node for PathSegment");

---

crates/cairo-lang-syntax-codegen/src/generator.rs line 609 at r1 (raw file):

        body.extend(quote! {
            pub fn $name(&self, db: &dyn SyntaxGroup) -> $kind {
                $kind::from_syntax_node(db, self.node.get_children(db)[$i])

can you separate the children save to another PR?

Code quote:

                $kind::from_syntax_node(db, self.node.get_children(db)[$i])

[TomerStarkware]

Reviewable status: 8 of 10 files reviewed, 3 unresolved discussions (waiting on @orizi)

---

crates/cairo-lang-syntax/src/node/helpers.rs line 155 at r1 (raw file):

Previously, orizi wrote…

I don't understand the message.
same in the other 2.

Done.

---

crates/cairo-lang-syntax-codegen/src/generator.rs line 609 at r1 (raw file):

Previously, orizi wrote…

can you separate the children save to another PR?

I can, but this will remove the benefits of the text shortcut as self.children will be called anyway

[TomerStarkware]

Reviewable status: 8 of 10 files reviewed, 3 unresolved discussions (waiting on @orizi)

---

-- commits line 2 at r1:
Done.

[orizi]

Reviewed 2 of 10 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @TomerStarkware)

[orizi]

Reviewed 4 of 4 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @TomerStarkware)