Skip to content

feat: enable reuse of scan results #1424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
May 23, 2025
Merged

feat: enable reuse of scan results #1424

merged 17 commits into from
May 23, 2025

Conversation

tenstad
Copy link
Member

@tenstad tenstad commented May 21, 2025

Should split out test refactor in another PR if going forward with this. Cannot use same digest Sha in multiple tests anymore.

Should maybe check that ScanConfig matches, so that we don't take the results of a min-severity HIGH CIS when a new min-severity LOW CIS is supposed to be scanned.

@tenstad tenstad force-pushed the reuse-scan branch 2 times, most recently from a65e880 to 4b56805 Compare May 21, 2025 17:07
@tenstad tenstad marked this pull request as ready for review May 21, 2025 20:57
@tenstad tenstad requested a review from a team as a code owner May 21, 2025 20:57
Copy link
Member

@erikgb erikgb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a nice feature to try out! 👏

@mariatsji mariatsji self-requested a review May 23, 2025 07:28
@tenstad tenstad merged commit 337a519 into statnett:main May 23, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants