implement validator custody with column refill mechanism #7127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tersec
reviewed
May 5, 2025
tersec
reviewed
May 5, 2025
tersec
reviewed
May 5, 2025
tersec
reviewed
May 5, 2025
| for i in startIndex..<SLOTS_PER_EPOCH: | ||
| let blck = vcus.dag.getForkedBlock(blocks[int(i)]).valueOr: continue | ||
| withBlck(blck): | ||
| when typeof(forkyBlck).kind < ConsensusFork.Fulu: continue |
There was a problem hiding this comment.
Should this ever happen? it's much cheaper to detect this before the block is ever fetched from the database, based on the slot number + fork schedule.
There was a problem hiding this comment.
detect this before the block is ever fetched from the database
the only way to make this cheaper is to see if the earliest data column in the database is against a Fulu block only then it makes sense to skip this check, imo, otherwise everytime we pull a finalized block from the DB, it's safe to check the fork, also say it can be a situation just a couple epochs after Fulu transition that on wanting block range i get EEEEEEFFFFFFF, i want to refill only against the last Fulu blocks, and wanna continue for the first few Es, note that Es and Fs should ideally way more in number, this is just for an example
tersec
reviewed
May 5, 2025
tersec
reviewed
May 5, 2025
tersec
reviewed
May 5, 2025
tersec
reviewed
May 5, 2025
tersec
reviewed
May 5, 2025
tersec
reviewed
May 5, 2025
|
https://github.com/status-im/nimbus-eth2/actions/runs/14842398481/job/41668253800?pr=7127 |
tersec
reviewed
May 12, 2025
tersec
reviewed
May 12, 2025
tersec
reviewed
May 13, 2025
…on for the validator custody loop
tersec
reviewed
Jun 26, 2025
| dataColumnRefillEpoch.start_slot, blocks.toOpenArray(0, SLOTS_PER_EPOCH - 1)) | ||
| for i in startIndex..<SLOTS_PER_EPOCH: | ||
| dataColumnRefillEpoch.start_slot, blocks.toOpenArray(0, slot.epoch().int - 1)) | ||
| for i in startIndex..<slot.epoch().int: |
There was a problem hiding this comment.
practically save but not that great to do this because (a) in theory 32/64-bit differences and (b) introduces potential Defect due to int conversion
There was a problem hiding this comment.
I see i also has to be int(i) a couple lines later, worth looking at the types here holistically.
There was a problem hiding this comment.
it's the same technique used in pruneSidecars
There was a problem hiding this comment.
It's not really great there either, but sure, it's consistent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.